fix(hooks): keep the composed bundle bake out of the layout and link gates #805

Merged

coilysiren merged 1 commit from aos/claude/wy58-bundles-not-content into main

2026-08-15 15:56:43 +00:00

coilyco-ops commented

2026-08-15 15:53:14 +00:00

Member

Closes #800. Consumer-side half. The upstream fix is coilyco-flight-deck/agentic-os#1063.

What changed

Two [tool.agentic-os.*] exclude entries in pyproject.toml, for documentation-layout and dead-cross-links, covering agent/bundles/**.

Why config rather than a code fix here

Nothing in this repository is wrong. The 75 layout violations are upstream agent-compose skills landing at paths this repository's rules do not allow, and the 8 dead links are real relative links between catalogue skills that a bundle does not carry, because a bundle holds only the skills its role admitted. Neither is fixable here and neither is this repository's content.

The gitignore did not help: both hooks walk the filesystem rather than git's file list, so agent/bundles/ being ignored was invisible to them, as was pre-commit's own exclude: directive.

Why both halves and not just the upstream one

This repository pins aos-precommit-v0.18.0. The upstream fix reaches it only when that rev moves, so without these two entries compose-bundles stays broken in the meantime. The comment above them says to drop both once the pinned rev passes the fix, so this does not become a permanent carve-out nobody revisits.

Verification

The issue's own reproduction, in order, with the pinned v0.18.0 hooks:

ward exec compose-bundles     # bundles on disk
ward gate                     # build/policy-check/vet/test/test-skips/pre-commit all PASS

Previously: 75 documentation layout violation(s) and 8 dead link(s).

Note on #788

ward exec role-drift-check bakes to a scratch directory outside the tree so the test job's later pre-commit step stays green. That workaround is untouched here and still correct. This fixes the other path, the one a human runs when they want the bundles on disk to inspect.

🤖 Generated with Claude Code

Closes #800. Consumer-side half. The upstream fix is coilyco-flight-deck/agentic-os#1063. ## What changed Two `[tool.agentic-os.*]` exclude entries in `pyproject.toml`, for `documentation-layout` and `dead-cross-links`, covering `agent/bundles/**`. ## Why config rather than a code fix here Nothing in this repository is wrong. The 75 layout violations are upstream agent-compose skills landing at paths this repository's rules do not allow, and the 8 dead links are real relative links between catalogue skills that a bundle does not carry, because a bundle holds only the skills its role admitted. Neither is fixable here and neither is this repository's content. The gitignore did not help: both hooks walk the filesystem rather than git's file list, so `agent/bundles/` being ignored was invisible to them, as was pre-commit's own `exclude:` directive. ## Why both halves and not just the upstream one This repository pins `aos-precommit-v0.18.0`. The upstream fix reaches it only when that rev moves, so without these two entries `compose-bundles` stays broken in the meantime. The comment above them says to drop both once the pinned rev passes the fix, so this does not become a permanent carve-out nobody revisits. ## Verification The issue's own reproduction, in order, with the pinned v0.18.0 hooks: ``` ward exec compose-bundles # bundles on disk ward gate # build/policy-check/vet/test/test-skips/pre-commit all PASS ``` Previously: `75 documentation layout violation(s)` and `8 dead link(s)`. ## Note on #788 `ward exec role-drift-check` bakes to a scratch directory outside the tree so the `test` job's later `pre-commit` step stays green. That workaround is untouched here and still correct. This fixes the other path, the one a human runs when they want the bundles on disk to inspect. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

coilyco-ops added 1 commit

2026-08-15 15:53:15 +00:00

fix(hooks): keep the composed bundle bake out of the layout and link gates

ci / image-build (pull_request) Successful in 24s

Details

ci / test (pull_request) Successful in 48s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

6c4d58dcde

`ward exec compose-bundles` writes agent/bundles/, which is gitignored. The
next `ward gate` reported 75 documentation-layout violations and 8 dead links
on an otherwise clean main, all inside that bake. Both hooks walk the
filesystem rather than git's file list, so the gitignore and pre-commit's own
exclude directive were equally invisible to them.

None of it is fixable here. The layout violations are upstream agent-compose
skills at paths this repository's rules do not allow, and the dead links are
real relative links between catalogue skills that a bundle does not carry,
because a bundle holds only the skills its role admitted.

The real fix is upstream and asks git what the repository holds rather than
taking a pattern list. These two excludes carry this repository until the
pinned aos-precommit rev moves past it, and the comment says to drop them then.

Verified by the issue's own reproduction: compose-bundles then gate, green.

Closes #800

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-15 15:53:15 +00:00

coilyco-ops referenced this pull request from coilyco-flight-deck/agentic-os

2026-08-15 15:53:33 +00:00

fix(hooks): a gitignored bake is not the repository's own content #1063