The indistinguishable-values entry for 542 records the diagnosis and not the resolution #704

Closed
opened 2026-08-13 20:05:05 +00:00 by coilyco-ops · 0 comments
Member

The entry for issue 542 in docs/sirens-echo-indistinguishable-values.md was written before the fix and ends on a conclusion the fix did not follow:

Fixing one caller does not retire a default that is also a live service.

True, and incomplete in the way that matters. The default could not be retired at all. Echo's own deployment sets no instance name and relies on it, so renaming the fallback would have renamed a live service and refusing to start would have crash-looped it. The resolution was narrower: refuse the default only where it lies, which is an unset name paired with a definition that is not Echo's.

That is the part worth recording, because the doc's whole subject is defaults that read as real values. A reader who takes the current entry at face value concludes the fix is "stop defaulting", tries it, and breaks Echo.

Constraint worth noting

The file was 75 lines and 3934 characters after the edit, against caps of 80 lines and 4000 characters. Fitting the resolution meant tightening the existing sentences rather than only appending, and dropping a second cross-reference that would have cost about 105 characters. This is issue 537's pressure showing up again in the same file, and it is recorded here rather than argued there.

Acceptance

  • The entry states why retiring the default was unavailable, not only that fixing one caller was insufficient.
  • The file stays inside both caps.

Next owner

Engineer. Closed by the pull request that lands the change.

The entry for [issue 542](https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/542) in `docs/sirens-echo-indistinguishable-values.md` was written before the fix and ends on a conclusion the fix did not follow: > Fixing one caller does not retire a default that is also a live service. True, and incomplete in the way that matters. **The default could not be retired at all.** Echo's own deployment sets no instance name and relies on it, so renaming the fallback would have renamed a live service and refusing to start would have crash-looped it. The resolution was narrower: refuse the default only where it lies, which is an unset name paired with a definition that is not Echo's. That is the part worth recording, because the doc's whole subject is defaults that read as real values. A reader who takes the current entry at face value concludes the fix is "stop defaulting", tries it, and breaks Echo. ## Constraint worth noting The file was 75 lines and 3934 characters after the edit, against caps of 80 lines and 4000 characters. Fitting the resolution meant tightening the existing sentences rather than only appending, and dropping a second cross-reference that would have cost about 105 characters. This is [issue 537](https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/537)'s pressure showing up again in the same file, and it is recorded here rather than argued there. ## Acceptance - The entry states why retiring the default was unavailable, not only that fixing one caller was insufficient. - The file stays inside both caps. ## Next owner Engineer. Closed by the pull request that lands the change.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-gaming/sirens-echo#704
No description provided.