refactor(tuning): gather the nineteen numbers that escaped the tuning file #664

Merged

coilyco-ops merged 1 commit from coilyco-ops/gather-the-escaped-numbers into main

2026-08-13 18:13:59 +00:00

AGit

coilyco-ops commented

2026-08-13 18:12:12 +00:00

Member

closes #659 - nineteen constants moved back into tuning.go, two of them into sections that were already empty and waiting; eight file modes, sentinels and check thresholds deliberately left

coilyco-ops added 1 commit

2026-08-13 18:12:12 +00:00

refactor(tuning): gather the nineteen numbers that escaped the tuning file

ci / image-build (pull_request) Successful in 30s

Details

ci / test (pull_request) Successful in 43s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

1615d27fec

sirens-echo#368 put every tuning number in internal/community/tuning.go.
Nineteen have since been declared beside the code that uses them. This
moves them back, comments intact.

Two of them had escaped into sections that were already waiting for
them. "Job progress" was an empty const block and jobProgressEvery was
in jobprogress.go. "Scratch space" listed four bounds and
maxScratchPartitionBytes was in scratch.go. So the file was not merely
incomplete, it was describing a shape it no longer held.

Eight numbers stay where they are, deliberately. Three are file modes,
one is a sentinel, and four are thresholds a check is built around
rather than knobs anyone would turn. Moving those would make the
tuning file a junk drawer and bury the numbers worth finding.

The knob-versus-fact split is a judgement and it is written on the
issue for Kai to overrule. Moving the other eight is one commit.

reactions.go no longer imports time.

Refs sirens-echo#659

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 18:12:12 +00:00

coilyco-ops referenced this pull request

2026-08-13 18:12:36 +00:00

Take another pass at moving all the numbers into a single file #659

coilyco-ops merged commit 97b9c9cb4d into main

2026-08-13 18:13:59 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 18:14:01 +00:00

Merge pull request 'refactor(tuning): gather the nineteen numbers that escaped the tuning file' (#664) from coilyco-ops/gather-the-escaped-numbers into main

coilyco-ops referenced this pull request

2026-08-18 20:04:14 +00:00