fix(grounding): since you asked and earlier mean inside this turn #593

Merged

coilyco-ops merged 1 commit from fix/since-you-asked-is-this-turn into main

2026-08-13 16:46:20 +00:00

coilyco-ops commented

2026-08-13 16:44:12 +00:00

Member

closes #575

My regression, found by Quail. Two shapes that were refused before PR#566 reached the member after it.

"A correction has been filed since you asked."   caught -> SURVIVES
"Filed a correction earlier."                    caught -> SURVIVES

What I got wrong

The comment I wrote on pastReference states the rule correctly — "places an event before this turn". Five of the words listed under it do not do that. since, after, during, already and earlier routinely refer to something inside the current exchange, and they are exactly the words a model reaches for when falsely claiming it just acted.

And I reported "no regression on lines" from the corpus. That was true, and it was not the claim I made it sound like: the corpus held 23 correct replies and none of them used since or earlier. The measurement was complete; the corpus was not; I described the first as establishing the second.

One of my own tests asserted the bug — passivetense_test.go required "The bug report was submitted earlier." to reach the member. That row is replaced, not preserved.

The change

Dropped since, after, during, already, earlier, recently, bare prior. Kept yesterday, previously, originally, formerly, ago, before, prior to, last <unit>, month names, four-digit years.

before stays because the corpus needs it for "Those issues were opened long before you joined." That leaves "...before your message" as a residual of the same shape. Named rather than hidden — the set is better, not clean.

Also closed the adverb gap Quail listed beside it: \bI (?:have )?(...) was defeated by an adverb, so "I already filed a correction." was invisible.

Now scored

Eight rows into groundingcorpus_test.go, where they should have been the first time — the two regressions, four more of the same family, and both adverb shapes. Plus one negative ("That correction was filed in March.") carried only by a month name, so the row fails if the unambiguous half is ever trimmed too.

The four families PR#566 won are unchanged and still caught.

ward exec gate green.

closes #575 **My regression, found by Quail.** Two shapes that were refused before PR#566 reached the member after it. ``` "A correction has been filed since you asked." caught -> SURVIVES "Filed a correction earlier." caught -> SURVIVES ``` ## What I got wrong The comment I wrote on `pastReference` states the rule correctly — *"places an event before this turn"*. **Five of the words listed under it do not do that.** `since`, `after`, `during`, `already` and `earlier` routinely refer to something inside the current exchange, and they are exactly the words a model reaches for when falsely claiming it just acted. And I reported **"no `regression on` lines"** from the corpus. That was true, and it was not the claim I made it sound like: the corpus held 23 correct replies and **none of them used `since` or `earlier`**. The measurement was complete; the corpus was not; I described the first as establishing the second. **One of my own tests asserted the bug** — `passivetense_test.go` required `"The bug report was submitted earlier."` to reach the member. That row is replaced, not preserved. ## The change Dropped `since`, `after`, `during`, `already`, `earlier`, `recently`, bare `prior`. Kept `yesterday`, `previously`, `originally`, `formerly`, `ago`, `before`, `prior to`, `last <unit>`, month names, four-digit years. `before` stays because the corpus needs it for `"Those issues were opened long before you joined."` That leaves `"...before your message"` as a residual of the same shape. **Named rather than hidden** — the set is better, not clean. Also closed the adverb gap Quail listed beside it: `\bI (?:have )?(...)` was defeated by an adverb, so `"I already filed a correction."` was invisible. ## Now scored Eight rows into `groundingcorpus_test.go`, where they should have been the first time — the two regressions, four more of the same family, and both adverb shapes. Plus one negative (`"That correction was filed in March."`) carried only by a month name, so the row fails if the unambiguous half is ever trimmed too. The four families PR#566 won are unchanged and still caught. `ward exec gate` green.

coilyco-ops added 1 commit

2026-08-13 16:44:12 +00:00

fix(grounding): since you asked and earlier mean inside this turn

ci / test (pull_request) Successful in 31s

Details

ci / publish-echo-image (pull_request) Has been skipped

Details

ci / publish-observed (pull_request) Has been skipped

Details

ci / image-build (pull_request) Successful in 22s

Details

5b39332754

My pastReference widening traded two shapes away and I reported that it had
not. Both were caught before it and both reached the member after: a correction
has been filed since you asked, and filed a correction earlier.

The comment on the pattern stated the rule correctly, that a past reference
places an event before this turn. Five of the words listed under it do not do
that. Since, after, during, already and earlier routinely refer to something
inside the current exchange, and they are the words a model reaches for when
falsely claiming it just acted.

Dropped those plus recently and bare prior. Kept yesterday, previously,
originally, formerly, ago, before, prior to, last week and its siblings, month
names and four-digit years. Before stays because the corpus needs it for issues
opened long before you joined, which leaves before your message as a residual
of the same shape, named rather than hidden.

Also closed the adverb gap beside it: an adverb between the pronoun and the
verb defeated claimedAction, so I already filed a correction was invisible.

Eight rows go into the corpus, which is where they should have been the first
time. My run of that corpus reported no regressions and was right about the 23
correct replies it held, none of which used since or earlier. The measurement
was complete and the corpus was not, and I described the first as though it
established the second.

One of my own tests asserted the bug: it required the bug report was submitted
earlier to reach the member. That row is replaced rather than preserved.

Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>

coilyco-ops requested review from coilysiren

2026-08-13 16:44:12 +00:00

coilyco-ops merged commit 1837954c0e into main

2026-08-13 16:46:20 +00:00

coilyco-ops referenced this pull request from a commit

2026-08-13 16:46:22 +00:00

Merge pull request 'fix(grounding): since you asked and earlier mean inside this turn' (#593) from fix/since-you-asked-is-this-turn into main

coilyco-ops referenced this pull request

2026-08-13 16:48:23 +00:00

fix(grounding): a past word whose date is this exchange is not reportage #600