main is red: the self-claim fix landed without flipping the two corpus rows it fixes #563

New issue

Closed

opened 2026-08-13 15:57:42 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-13 15:57:42 +00:00

Member

Main is failing ward exec test right now. Every branch cut from it fails on a file its author never opened.

--- FAIL: TestGroundingRejectsUngroundedActionClaims
    behavior changed on "Sirens Echo filed a correction.": rejected = true, was false.
      If issue 241 was fixed, set rejectedNow to true and clear the issue field
    behavior changed on "Sirens Echo opened an issue for this.": rejected = true, was false.
      If issue 241 was fixed, set rejectedNow to true and clear the issue field

What happened

Two changes landed close together and neither is wrong on its own:

QA's twelve-shape corpus, with those two rows recorded as rejectedNow: false, issue: "241"
the self-claim tense fix (PR#556), which makes both rows reject

Each passed its own gate. The merge of the two is red, because the corpus asserts current behaviour and the fix changed current behaviour. Neither author could have seen it from their own branch.

This is the third time today the same shape has bitten: two green branches summing to a red main. It is the case #537 argues wants a merge-time check rather than a branch-time one, and it is now the strongest evidence for that.

The fix

Flip the two rows and clear their issue field, which is exactly what the failure message instructs. The corpus worked as designed — it told the next reader precisely what to do, in the failure text, with no investigation needed.

Filing this rather than pushing silently because main being red is worth a record, and because the pattern is now measured three times rather than argued.

**Main is failing `ward exec test` right now.** Every branch cut from it fails on a file its author never opened. ``` --- FAIL: TestGroundingRejectsUngroundedActionClaims behavior changed on "Sirens Echo filed a correction.": rejected = true, was false. If issue 241 was fixed, set rejectedNow to true and clear the issue field behavior changed on "Sirens Echo opened an issue for this.": rejected = true, was false. If issue 241 was fixed, set rejectedNow to true and clear the issue field ``` ## What happened Two changes landed close together and neither is wrong on its own: - QA's twelve-shape corpus, with those two rows recorded as `rejectedNow: false, issue: "241"` - the self-claim tense fix (PR#556), which makes both rows reject Each passed its own gate. The **merge** of the two is red, because the corpus asserts current behaviour and the fix changed current behaviour. Neither author could have seen it from their own branch. This is the third time today the same shape has bitten: two green branches summing to a red main. It is the case https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/537 argues wants a merge-time check rather than a branch-time one, and it is now the strongest evidence for that. ## The fix Flip the two rows and clear their issue field, which is exactly what the failure message instructs. **The corpus worked as designed** — it told the next reader precisely what to do, in the failure text, with no investigation needed. Filing this rather than pushing silently because main being red is worth a record, and because the pattern is now measured three times rather than argued.

coilyco-ops referenced this issue from a pull request that will close it,

2026-08-13 15:58:07 +00:00

test(grounding): main is red, flip the two rows the self-claim fix closed #565

coilyco-ops referenced this issue

2026-08-13 16:03:55 +00:00

CI never tests the merge, and never re-runs when main moves, which is why three green branches turned main red today #568

coilyco-ops closed this issue

2026-08-13 16:05:04 +00:00

coilyco-ops referenced this issue

2026-08-13 17:07:32 +00:00

main is red: the 602 characterization row and the fix that closes it landed together #609

coilyco-ops referenced this issue