Repair the regression where the tool footer shortens a member's issue link #417

New issue

Closed

opened 2026-08-13 12:28:26 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-13 12:28:26 +00:00

Member

Slice of #413, filed under the partial-delivery rule in AGENTS.md. 413 stays open for the correct fix.

What this repairs

#403 gave the disclosure footer a transport budget and made the issue reference the casualty, because references are appended first and the budget shortens whatever precedes the footer. Measured on main at the ceiling: the reference goes, the footer stays.

That is a regression I introduced, against behaviour older than the footer. References always survived before 403. I traded an existing member-facing guarantee for a feature shipped an hour earlier, and I did not notice until I tested my own change rather than reasoning about it.

Why this is not the product judgement I called it

I framed which-suffix-survives as a decision for Kai, twice. That was wrong, and I would rather correct it than wait on an answer I should not have asked for.

Restoring a guarantee that predates the change is the conservative repair of a regression, not a new trade. The footer is one hour old. The reference is what a member uses to reach work filed on their behalf. Nothing about that needed deciding.

Scope

The budget is withheld only when a reference was actually added. Every turn with nothing to protect still gets the full footer budget, which is the common case and the one #385 was about.

So this is strictly better than both prior states: before 403 the footer was always lost at the ceiling, after 403 the reference was, and now neither is lost unless both are present.

Explicitly not the fix on 413

Keeping both suffixes needs references resolved against the already-truncated answer, because truncating can remove a short reference the suffix resolves and a naive version ships a link to something the member cannot see. That work, its convergence argument, and its acceptance criteria stay on 413.

Acceptance

A reply at the ceiling carrying a reference keeps the reference.
A reply at the ceiling with no reference keeps the footer.
An unbounded transport is unaffected.

Mutation checked: disabling the rule returns the full budget and the guard fails naming the number.

Angie (ENG) · s/4b1e.

Slice of https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/413, filed under the partial-delivery rule in `AGENTS.md`. 413 stays open for the correct fix. ## What this repairs https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/pulls/403 gave the disclosure footer a transport budget and made the issue reference the casualty, because references are appended first and the budget shortens whatever precedes the footer. Measured on `main` at the ceiling: the reference goes, the footer stays. **That is a regression I introduced**, against behaviour older than the footer. References always survived before 403. I traded an existing member-facing guarantee for a feature shipped an hour earlier, and I did not notice until I tested my own change rather than reasoning about it. ## Why this is not the product judgement I called it I framed which-suffix-survives as a decision for Kai, twice. That was wrong, and I would rather correct it than wait on an answer I should not have asked for. Restoring a guarantee that predates the change is the conservative repair of a regression, not a new trade. The footer is one hour old. The reference is what a member uses to reach work filed on their behalf. Nothing about that needed deciding. ## Scope The budget is withheld only when a reference was actually added. Every turn with nothing to protect still gets the full footer budget, which is the common case and the one https://forgejo.coilysiren.me/coilyco-gaming/sirens-echo/issues/385 was about. So this is strictly better than both prior states: before 403 the footer was always lost at the ceiling, after 403 the reference was, and now neither is lost unless both are present. ## Explicitly not the fix on 413 Keeping **both** suffixes needs references resolved against the already-truncated answer, because truncating can remove a short reference the suffix resolves and a naive version ships a link to something the member cannot see. That work, its convergence argument, and its acceptance criteria stay on 413. ## Acceptance - A reply at the ceiling carrying a reference keeps the reference. - A reply at the ceiling with no reference keeps the footer. - An unbounded transport is unaffected. Mutation checked: disabling the rule returns the full budget and the guard fails naming the number. Angie (ENG) · s/4b1e.

coilyco-ops referenced this issue from a commit

2026-08-13 12:28:46 +00:00

fix(reply): a member's link never loses room to the receipt

coilyco-ops referenced this issue from a pull request that will close it,

2026-08-13 12:28:46 +00:00

fix(reply): a member's link never loses room to the receipt #418

coilyco-ops referenced this issue

2026-08-13 12:35:29 +00:00

Index: the decisions this backlog is now waiting on, in one place #315

coilyco-ops referenced this issue

2026-08-13 12:47:31 +00:00

A fetched page over the size cap is truncated silently, so the model reads half a document as a whole one #435