The catalog suite is pinned fifteen versions back, so the git-workflow hook has never run here and AGENTS.md still carries the legacy lane stamp #1099

New issue

Open

opened 2026-08-22 21:25:31 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-22 21:25:31 +00:00

Member

Filed by Darren (director seat), 2026-08-22, from a review of #1096 where the gap surfaced.

The gap

.pre-commit-config.yaml pins the catalog suite at rev: aos-precommit-v0.24.0. The current tag is aos-precommit-v0.39.0, fifteen minor versions ahead.

One consequence is concrete and already visible. The git-workflow hook regenerates the managed git-workflow block in AGENTS.md offline and fails on drift. v0.24.0 does not contain that hook at all, verified against the tag rather than inferred, so this repo has never been held to it and its ## Agent rules section still carries the legacy hand-written **Git workflow** - stamp that the generator was written to replace.

That stamp is not merely old. Its text says the merge "stays director-gated", while this repo declares pull-request-and-merge, whose whole point is that the author of the code merges it. The generator's own docstring names that inversion as the failure it exists to prevent, and #1096 restored the sentence faithfully because the pre-swap text is what it went back to.

What this asks for

Bump rev to the current aos-precommit-v* tag.
Add - id: git-workflow to the hook list, so the block is generated and drift-checked rather than hand-written.
Run pre-commit run --all-files and deal with whatever fourteen versions of validator changes surface.

Why it is its own issue rather than a line in someone else's

Point 3 is the whole cost. This repo is at its docs/ page cap of 40 and has already tripped catalog-doc-size once on main, in the merge that #1081 cleaned up. A fifteen-version jump in a suite that includes size and layout validators is not a drive-by, and it should not ride along in a change about something else.

Done when

pre-commit run --all-files passes on the current tag with git-workflow in the hook list, and AGENTS.md carries the generated block rather than the legacy stamp.

#1096 - the lane revert that restored the legacy stamp, deliberately left as-is
agentic-os#1157 - the commit that added the hook and the generator

**Filed by Darren (director seat), 2026-08-22**, from a review of #1096 where the gap surfaced. ## The gap `.pre-commit-config.yaml` pins the catalog suite at `rev: aos-precommit-v0.24.0`. The current tag is **`aos-precommit-v0.39.0`**, fifteen minor versions ahead. One consequence is concrete and already visible. The `git-workflow` hook regenerates the managed git-workflow block in `AGENTS.md` offline and fails on drift. **`v0.24.0` does not contain that hook at all**, verified against the tag rather than inferred, so this repo has never been held to it and its `## Agent rules` section still carries the legacy hand-written `**Git workflow** -` stamp that the generator was written to replace. That stamp is not merely old. Its text says the merge "stays director-gated", while this repo declares `pull-request-and-merge`, whose whole point is that the author of the code merges it. The generator's own docstring names that inversion as the failure it exists to prevent, and #1096 restored the sentence faithfully because the pre-swap text is what it went back to. ## What this asks for 1. Bump `rev` to the current `aos-precommit-v*` tag. 2. Add `- id: git-workflow` to the hook list, so the block is generated and drift-checked rather than hand-written. 3. Run `pre-commit run --all-files` and deal with whatever fourteen versions of validator changes surface. ## Why it is its own issue rather than a line in someone else's **Point 3 is the whole cost.** This repo is at its `docs/` page cap of 40 and has already tripped `catalog-doc-size` once on `main`, in the merge that #1081 cleaned up. A fifteen-version jump in a suite that includes size and layout validators is not a drive-by, and it should not ride along in a change about something else. ## Done when `pre-commit run --all-files` passes on the current tag with `git-workflow` in the hook list, and `AGENTS.md` carries the generated block rather than the legacy stamp. ## Related * #1096 - the lane revert that restored the legacy stamp, deliberately left as-is * `agentic-os#1157` - the commit that added the hook and the generator

coilyco-ops added the

labels

2026-08-22 21:25:31 +00:00

coilyco-ops referenced this issue

2026-08-22 21:25:38 +00:00

chore(agents): return to the pull-request lane and restore the gate guard #1096

coilyco-ops referenced this issue

2026-08-22 23:16:42 +00:00