Two pre-existing violations in vendored unity/ trees, surfaced by the aos-precommit bump to v0.55.0 #34

New issue

Open

opened 2026-08-29 06:28:41 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-29 06:28:41 +00:00

Owner

Found while bumping this repo's aos-precommit pin from v0.33.0 to v0.55.0 for coilyco-flight-deck/agentic-os#1383. The bump landed (2598e34, f54a3f2) because pre-commit gates the files in a commit and neither of these is in one. pre-commit run --all-files still fails.

What fails

check-json

unity/ProjectSettings/Packages/com.unity.services.core/Settings.json:
  Failed to json decode (Expecting value: line 1 column 1 (char 0))

The file is 0 bytes and tracked. Unity's services-core package writes it empty, and an empty file is not valid JSON.

typos

`Ingores` should be `Ignores`   unity/Assets/EcoLibs/Utils/MiscUtils/ColliderUtils.cs:133
`doument` should be `document`  unity/Assets/EcoModKit/Docs/README.md:4

Both are in Eco SDK source as Strange Loop Games ships it.

Why I did not just fix them

pyproject.toml already states this repo's position on that tree:

unity/Assets/EcoModKit/ is the Eco SDK as upstream ships it, so cutting its docs forks them.

Correcting a typo in EcoModKit/Docs/README.md is the same fork the doc-size exclusion exists to avoid. EcoLibs is the same shape and is not currently in the vendored list.

And the generic exclusion does not apply. apply-agentic-os-hooks.py's vendored_exclude covers only hooks that rewrite content, and its docstring is deliberate about the rest:

Reporting hooks still read the tree, so a secret or a broken JSON there is still caught.

So suppressing check-json or typos across unity/ would contradict a decision someone already made on purpose. That is a call for whoever owns this repo, not a side effect of a pin bump.

Options, none taken

check-json: write {} into the Settings.json, or stop tracking it. It is Unity-generated, so the question is whether Unity rewrites it either way. That is a Unity-project question rather than a hooks one.
typos: add the two words to the existing _typos.toml, which already carries a proper-noun exception with its reason. That accepts upstream's spelling without editing upstream's files, which fits the stated position better than either fixing or excluding.

The second is cheap and I would have done it, except that declaring an upstream misspelling "correct" fleet-wide is a slightly different claim than the embeded entry already there, which is a real proper noun.

Not established

Whether unity/Assets/EcoLibs/ should join vendored in pyproject.toml alongside EcoModKit/. It looks like the same kind of tree, but I did not check whether it is upstream-shipped or locally authored, and that decides it.

Found while bumping this repo's `aos-precommit` pin from v0.33.0 to v0.55.0 for `coilyco-flight-deck/agentic-os#1383`. The bump landed (`2598e34`, `f54a3f2`) because pre-commit gates the files in a commit and neither of these is in one. `pre-commit run --all-files` still fails. ## What fails **check-json** ``` unity/ProjectSettings/Packages/com.unity.services.core/Settings.json: Failed to json decode (Expecting value: line 1 column 1 (char 0)) ``` The file is **0 bytes and tracked**. Unity's services-core package writes it empty, and an empty file is not valid JSON. **typos** ``` `Ingores` should be `Ignores` unity/Assets/EcoLibs/Utils/MiscUtils/ColliderUtils.cs:133 `doument` should be `document` unity/Assets/EcoModKit/Docs/README.md:4 ``` Both are in Eco SDK source as Strange Loop Games ships it. ## Why I did not just fix them `pyproject.toml` already states this repo's position on that tree: > unity/Assets/EcoModKit/ is the Eco SDK as upstream ships it, so cutting its docs forks them. Correcting a typo in `EcoModKit/Docs/README.md` is the same fork the doc-size exclusion exists to avoid. `EcoLibs` is the same shape and is not currently in the `vendored` list. And the generic exclusion does not apply. `apply-agentic-os-hooks.py`'s `vendored_exclude` covers only hooks that **rewrite** content, and its docstring is deliberate about the rest: > Reporting hooks still read the tree, so a secret or a broken JSON there is still caught. So suppressing check-json or typos across `unity/` would contradict a decision someone already made on purpose. That is a call for whoever owns this repo, not a side effect of a pin bump. ## Options, none taken * **check-json**: write `{}` into the Settings.json, or stop tracking it. It is Unity-generated, so the question is whether Unity rewrites it either way. That is a Unity-project question rather than a hooks one. * **typos**: add the two words to the existing `_typos.toml`, which already carries a proper-noun exception with its reason. That accepts upstream's spelling without editing upstream's files, which fits the stated position better than either fixing or excluding. The second is cheap and I would have done it, except that declaring an upstream misspelling "correct" fleet-wide is a slightly different claim than the `embeded` entry already there, which is a real proper noun. ## Not established Whether `unity/Assets/EcoLibs/` should join `vendored` in `pyproject.toml` alongside `EcoModKit/`. It looks like the same kind of tree, but I did not check whether it is upstream-shipped or locally authored, and that decides it.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-gaming/eco-mods#34

No description provided.

Rows
Columns