chore: pre-commit red on main - forked load-points and dead cross-links #32

New issue

Closed

opened 2026-08-20 06:48:37 +00:00 by coilyco-ops · 1 comment

coilyco-ops commented

2026-08-20 06:48:37 +00:00

Member

pre-commit run --all-files fails on current main, independent of any branch. Two catalog hooks are red. Found while fixing #28 (mods.py), filed separately because it is unrelated to that script.

1. context-load-points: forked load-point rungs

The hook holds that AGENTS.md and CLAUDE.md may live only at the repo root. Four real copies (mode 100644, not symlinks) sit in subdirectories and are flagged as forked rungs:

FAIL: mods/AGENTS.md
FAIL: mods/CLAUDE.md
FAIL: unity/AGENTS.md
FAIL: unity/CLAUDE.md
4 context load-point violation(s).

The hook's remedy is to symlink each to the canonical root file (sharing) or remove it. Note mods/AGENTS.md and unity/AGENTS.md carry distinct subtree-specific content, so this needs a decision, not a blind symlink: fold the subtree guidance the root file should own into the root AGENTS.md, and reduce the subdir files to shared symlinks or drop them. mods/CLAUDE.md and unity/CLAUDE.md are the 12-byte @AGENTS.md includes, so those can become symlinks to the root CLAUDE.md directly.

2. dead-cross-links

FAIL: mods/AGENTS.md:53          dead link (../eco-cycle-prep/AGENTS.md)
FAIL: unity-embedded/.agents/skills/repo-eco-mods-assets-embeded/SKILL.md:11  dead link (../../../AGENTS.md)      -> unity-embedded/AGENTS.md
FAIL: unity-embedded/.agents/skills/repo-eco-mods-assets-embeded/SKILL.md:12  dead link (../../../docs/FEATURES.md) -> unity-embedded/docs/FEATURES.md
3 dead link(s).

mods/AGENTS.md:53 points at ../eco-cycle-prep/, a deprecated sibling repo (canonical set is coilyco-gaming/{eco-app, eco-mods, eco-ops}). Re-home or drop that cross-reference.
The repo-eco-mods-assets-embeded skill links up three levels to unity-embedded/AGENTS.md and unity-embedded/docs/FEATURES.md, neither of which exists. Point the links at the real files (the repo root) or supply the missing ones. The assets-embeded spelling and the retired eco-mods-assets name in that skill directory also read as leftover consolidation rot worth a look.

Done means

pre-commit run --all-files green with no new [tool.agentic-os.*] excludes that reach these hooks.

`pre-commit run --all-files` fails on current `main`, independent of any branch. Two catalog hooks are red. Found while fixing #28 (mods.py), filed separately because it is unrelated to that script. ## 1. context-load-points: forked load-point rungs The hook holds that `AGENTS.md` and `CLAUDE.md` may live only at the repo root. Four real copies (mode `100644`, not symlinks) sit in subdirectories and are flagged as forked rungs: ``` FAIL: mods/AGENTS.md FAIL: mods/CLAUDE.md FAIL: unity/AGENTS.md FAIL: unity/CLAUDE.md 4 context load-point violation(s). ``` The hook's remedy is to symlink each to the canonical root file (sharing) or remove it. Note `mods/AGENTS.md` and `unity/AGENTS.md` carry distinct subtree-specific content, so this needs a decision, not a blind symlink: fold the subtree guidance the root file should own into the root `AGENTS.md`, and reduce the subdir files to shared symlinks or drop them. `mods/CLAUDE.md` and `unity/CLAUDE.md` are the 12-byte `@AGENTS.md` includes, so those can become symlinks to the root `CLAUDE.md` directly. ## 2. dead-cross-links ``` FAIL: mods/AGENTS.md:53 dead link (../eco-cycle-prep/AGENTS.md) FAIL: unity-embedded/.agents/skills/repo-eco-mods-assets-embeded/SKILL.md:11 dead link (../../../AGENTS.md) -> unity-embedded/AGENTS.md FAIL: unity-embedded/.agents/skills/repo-eco-mods-assets-embeded/SKILL.md:12 dead link (../../../docs/FEATURES.md) -> unity-embedded/docs/FEATURES.md 3 dead link(s). ``` - `mods/AGENTS.md:53` points at `../eco-cycle-prep/`, a deprecated sibling repo (canonical set is `coilyco-gaming/{eco-app, eco-mods, eco-ops}`). Re-home or drop that cross-reference. - The `repo-eco-mods-assets-embeded` skill links up three levels to `unity-embedded/AGENTS.md` and `unity-embedded/docs/FEATURES.md`, neither of which exists. Point the links at the real files (the repo root) or supply the missing ones. The `assets-embeded` spelling and the retired `eco-mods-assets` name in that skill directory also read as leftover consolidation rot worth a look. ## Done means `pre-commit run --all-files` green with no new `[tool.agentic-os.*]` excludes that reach these hooks.

coilyco-ops commented

2026-08-20 07:02:39 +00:00

Author

Member

Duplicate of #31, which predates this and covers the same ground more completely (it also has the size-cap analysis). #31 is now fixed and closed in e30202b: the aos-precommit rev bump to v0.33.0 made the vendored size-exemption effective, and the context-load-points excludes plus the dead-link repoints cleared the rest. Closing this as the duplicate. Filing it was my miss for not checking open issues first.

Duplicate of #31, which predates this and covers the same ground more completely (it also has the size-cap analysis). #31 is now fixed and closed in `e30202b`: the `aos-precommit` rev bump to v0.33.0 made the `vendored` size-exemption effective, and the `context-load-points` excludes plus the dead-link repoints cleared the rest. Closing this as the duplicate. Filing it was my miss for not checking open issues first.

coilyco-ops closed this issue

2026-08-20 07:02:46 +00:00