price_recipe ranks the recipe where nothing priced as the cheapest #285

New issue

Closed

opened 2026-08-13 22:38:15 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-13 22:38:15 +00:00

Member

Slice of #266, filed so PR #272 closes what it actually closes. Angie (ENG, claude seat).

recipe             totalCost  ingredientCost  priced ingredients
RecycledIronBar         0.22               0  0 of 2
IronBar                 1.46            1.28  1 of 2
SmeltIron               3.18            2.56  1 of 2

Sorted by cost, the recipe where nothing resolved wins by 7x. ingredientCost: 0 means "no leaf priced", not "the ingredients are free", and it is the only comparable-looking number in the row.

perUnitCost already goes None when complete is false. totalCost and ingredientCost did not, so one payload disagreed with itself.

Acceptance

totalCost and ingredientCost are null whenever complete is false, matching perUnitCost.
A complete rollup still reports its numbers. Unpriced is not the same as free.
ingredients[] and unpricedInputs still show how far the rollup got.
The frontend types widen to number | null and the ingredient-cost cell takes the null guard the per-unit cell already had.
Fails under a mutation restoring the partial sum.

**Slice of https://forgejo.coilysiren.me/coilyco-gaming/eco-app/issues/266, filed so PR https://forgejo.coilysiren.me/coilyco-gaming/eco-app/pulls/272 closes what it actually closes.** Angie (ENG, `claude` seat). ``` recipe totalCost ingredientCost priced ingredients RecycledIronBar 0.22 0 0 of 2 IronBar 1.46 1.28 1 of 2 SmeltIron 3.18 2.56 1 of 2 ``` Sorted by cost, the recipe where **nothing** resolved wins by 7x. `ingredientCost: 0` means "no leaf priced", not "the ingredients are free", and it is the only comparable-looking number in the row. `perUnitCost` already goes `None` when `complete` is false. `totalCost` and `ingredientCost` did not, so one payload disagreed with itself. ## Acceptance - `totalCost` and `ingredientCost` are `null` whenever `complete` is false, matching `perUnitCost`. - A complete rollup still reports its numbers. Unpriced is not the same as free. - `ingredients[]` and `unpricedInputs` still show how far the rollup got. - The frontend types widen to `number | null` and the ingredient-cost cell takes the null guard the per-unit cell already had. - Fails under a mutation restoring the partial sum.

coilyco-ops referenced this issue from a pull request that will close it,

2026-08-13 22:38:22 +00:00

fix(cost): an unpriced rollup reports no total rather than zero #272