get_stores returns empty currencies[] on stores with thousands in trade volume #236

New issue

Closed

opened 2026-08-12 23:15:55 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-12 23:15:55 +00:00

Member

QA sweep, Eco via Sirens, day 40, 2026-08-12.

Observed

The busiest store on the server comes back with no currency:

{"label":"Upgrade's Store","owner":"Upgrade","location":"237,68,962",
 "tradeCount":48,"buyCount":7,"sellCount":41,"totalVolume":4615.47,
 "currencies":[],
 "topItems":[{"item":"ReinforcedConcreteItem","volume":1145.25,"avgUnitPrice":1.575}, …]}

totalVolume: 4615.47 and per-item avgUnitPrice are computed, but currencies is empty — the volume is denominated in nothing.

Almost certainly the same root cause

get_trades has currency: "" on all 526 detailed rows. See the get_currency attribution issue. Filing separately so this surface gets verified after that fix rather than assumed.

Cross-check

find_trade resolves currency for the same owner's live shelves: "Upgrade's Phantom Springs Stone & Glassworks" selling Cement at 0.6 Spectres. So live store data has currency and the historical ledger path does not.

Expected

currencies populated, and totalVolume broken out per currency — mixing volumes across currencies into a single scalar is not meaningful once more than one currency is in play (185 exist on this server).

QA sweep, Eco via Sirens, day 40, 2026-08-12. ## Observed The busiest store on the server comes back with no currency: ```json {"label":"Upgrade's Store","owner":"Upgrade","location":"237,68,962", "tradeCount":48,"buyCount":7,"sellCount":41,"totalVolume":4615.47, "currencies":[], "topItems":[{"item":"ReinforcedConcreteItem","volume":1145.25,"avgUnitPrice":1.575}, …]} ``` `totalVolume: 4615.47` and per-item `avgUnitPrice` are computed, but `currencies` is empty — the volume is denominated in nothing. ## Almost certainly the same root cause `get_trades` has `currency: ""` on all 526 detailed rows. See the `get_currency` attribution issue. Filing separately so this surface gets verified after that fix rather than assumed. ## Cross-check `find_trade` resolves currency for the same owner's live shelves: "Upgrade's Phantom Springs Stone & Glassworks" selling Cement at 0.6 **Spectres**. So live store data has currency and the historical ledger path does not. ## Expected `currencies` populated, and `totalVolume` broken out per currency — mixing volumes across currencies into a single scalar is not meaningful once more than one currency is in play (185 exist on this server).

coilyco-ops referenced this issue

2026-08-12 23:34:54 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue

2026-08-12 23:36:09 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue

2026-08-12 23:47:23 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue

2026-08-13 05:33:59 +00:00

get_currency attributes every trade to numeric currency IDs; all named currencies report zero #217