get_crafting_atlas byCitizen returns values 15x larger than totalEvents and means something different from get_world.byCitizen #222

New issue

Closed

opened 2026-08-12 23:13:38 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-12 23:13:38 +00:00

Member

QA sweep, Eco via Sirens, day 40, 2026-08-12.

Observed

get_crafting_atlas reports totalEvents: 18092, then:

"byCitizen": [["Kirdec", 281506], ["Scuba Steve", 211919], ["Upgrade", 152910]]

One citizen's value is 15× the entire event total for the server.

perActionCounts itself is internally consistent (9,829 + 3,803 + 1,331 + 3,129 = 18,092 = totalEvents), so the aggregate is fine — byCitizen is summing something else, most likely item quantities.

Cross-tool conflict

get_world.byCitizen uses the same key name for event counts: [["Kirdec", 1031], ["Scuba Steve", 777], …]. Same field name, same tool family, two different units, neither labelled.

Expected

Either rename to byCitizenQuantity (and keep an event-count byCitizen for parity with get_world), or sum events. Any value that exceeds totalEvents under an event-shaped name is going to be read wrong.

QA sweep, Eco via Sirens, day 40, 2026-08-12. ## Observed `get_crafting_atlas` reports `totalEvents: 18092`, then: ```json "byCitizen": [["Kirdec", 281506], ["Scuba Steve", 211919], ["Upgrade", 152910]] ``` One citizen's value is 15× the entire event total for the server. `perActionCounts` itself is internally consistent (9,829 + 3,803 + 1,331 + 3,129 = 18,092 = `totalEvents`), so the aggregate is fine — `byCitizen` is summing something else, most likely item quantities. ## Cross-tool conflict `get_world.byCitizen` uses the same key name for event counts: `[["Kirdec", 1031], ["Scuba Steve", 777], …]`. Same field name, same tool family, two different units, neither labelled. ## Expected Either rename to `byCitizenQuantity` (and keep an event-count `byCitizen` for parity with `get_world`), or sum events. Any value that exceeds `totalEvents` under an event-shaped name is going to be read wrong.

coilyco-ops referenced this issue

2026-08-12 23:34:54 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue

2026-08-12 23:36:09 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue

2026-08-12 23:47:23 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue from a commit

2026-08-13 04:53:25 +00:00

fix(crafting): make byCitizen an event count, matching get_world