Trade totals disagree across get_economy, get_market, get_stores and get_trades (1,699 vs 22,891 vs 3,672 vs 526) #221

New issue

Closed

opened 2026-08-12 23:13:27 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-12 23:13:27 +00:00

Member

QA sweep, Eco via Sirens, day 40, 2026-08-12.

Observed

Four numbers, all presented as trade counts, none reconciled:

Source	Field	Value
`/info` via `get_server_status`	`economy.description`	1,699 trades
`get_economy`	`kpis.trades_total`	1,699
`get_trades` / `get_market` / `get_stores`	`totalTrades`	22,891
`get_trades`	`rollupTrades` + `detailedTrades`	22,365 + 526 = 22,891
`get_trades` / `get_stores`	`perTypeCounts` (CurrencyTrade 3,668 + BarterTrade 4)	3,672
`get_trades`	`trades[]` length	526

Two specific breaks:

perTypeCounts reconciles with nothing. 3,672 is not 526 (detailed rows), not 22,891 (total), not 22,365 (rollup). It is presented right next to detailedTrades: 526 in the same object.
13× headline gap. get_economy says 1,699 trades and derives trades_per_day: 42.5 from it; the ledger tools say 22,891. A reader comparing the two tools gets contradictory economic conclusions with no note that the sources differ.

Expected

Either one number, or each number labelled with what it counts and why it differs from the game's own counter. The rollup warning at #132 explains detailed-vs-rollup but does not explain either of the above.

QA sweep, Eco via Sirens, day 40, 2026-08-12. ## Observed Four numbers, all presented as trade counts, none reconciled: | Source | Field | Value | |---|---|---| | `/info` via `get_server_status` | `economy.description` | **1,699 trades** | | `get_economy` | `kpis.trades_total` | **1,699** | | `get_trades` / `get_market` / `get_stores` | `totalTrades` | **22,891** | | `get_trades` | `rollupTrades` + `detailedTrades` | 22,365 + 526 = 22,891 | | `get_trades` / `get_stores` | `perTypeCounts` (CurrencyTrade 3,668 + BarterTrade 4) | **3,672** | | `get_trades` | `trades[]` length | **526** | Two specific breaks: 1. **`perTypeCounts` reconciles with nothing.** 3,672 is not 526 (detailed rows), not 22,891 (total), not 22,365 (rollup). It is presented right next to `detailedTrades: 526` in the same object. 2. **13× headline gap.** `get_economy` says 1,699 trades and derives `trades_per_day: 42.5` from it; the ledger tools say 22,891. A reader comparing the two tools gets contradictory economic conclusions with no note that the sources differ. ## Expected Either one number, or each number labelled with what it counts and why it differs from the game's own counter. The rollup warning at https://forgejo.coilysiren.me/coilyco-gaming/eco-app/issues/132 explains detailed-vs-rollup but does not explain either of the above.

coilyco-ops referenced this issue

2026-08-12 23:34:54 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue

2026-08-12 23:36:09 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue

2026-08-12 23:47:23 +00:00

Tracking: 2026-08-12 full-surface QA sweep of the eco MCP (22 tools, 23 findings) #240

coilyco-ops referenced this issue from a commit

2026-08-13 04:57:52 +00:00

fix(trades): label what each trade count counts