coilyco-gaming/eco-app

Watch

frontend vitest: PagePassword tests fail locally - localStorage undefined in test env #133

New issue

Closed

opened 2026-07-21 04:15:30 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-21 04:15:30 +00:00

Member

Dev-env papercut noticed while landing #131. All 4 src/components/PagePassword.test.tsx cases fail on a fresh local ward exec frontend-test with TypeError: Cannot read properties of undefined (reading 'clear') at the localStorage.clear() in beforeEach/afterEach - localStorage is undefined in the local vitest environment (macOS host, fresh pnpm install 2026-07-21). Unrelated to the #131 change (that change touched craftingApi.ts / Crafting.tsx / Item.tsx only, and the other 23 test files pass). CI runs in the pinned dev-base image and is presumably green - needs a look at the vitest environment config (jsdom/happy-dom) so local runs match CI.

Dev-env papercut noticed while landing #131. All 4 `src/components/PagePassword.test.tsx` cases fail on a fresh local `ward exec frontend-test` with `TypeError: Cannot read properties of undefined (reading 'clear')` at the `localStorage.clear()` in beforeEach/afterEach - `localStorage` is undefined in the local vitest environment (macOS host, fresh pnpm install 2026-07-21). Unrelated to the #131 change (that change touched craftingApi.ts / Crafting.tsx / Item.tsx only, and the other 23 test files pass). CI runs in the pinned dev-base image and is presumably green - needs a look at the vitest environment config (jsdom/happy-dom) so local runs match CI.

coilyco-ops added the

labels

2026-07-23 05:20:58 +00:00

coilyco-ops referenced this issue from a commit

2026-07-23 05:27:08 +00:00

test: use jsdom storage in password gate tests

coilyco-ops closed this issue

2026-07-23 05:27:08 +00:00

coilyco-ops commented

2026-07-23 05:27:40 +00:00

Author

Member

WARDED_WORKFLOW: done ✅

details

review summary: in-container review gate skipped (temporary ward default pending brokered QA); frontend test/lint/build and full test/lint passed.
workflow: merge-remote-main; review summary: in-container review skipped (temporary ward default pending brokered QA).
felt: surgical and low-risk.
confidence: high.
surprises: the container initially lacked a runnable pnpm shim; Corepack resolved it outside the repository.
follow-ups: none.

WARDED_WORKFLOW: done ✅ <details><summary>details</summary> review summary: in-container review gate skipped (temporary ward default pending brokered QA); frontend test/lint/build and full test/lint passed. workflow: merge-remote-main; review summary: in-container review skipped (temporary ward default pending brokered QA). felt: surgical and low-risk. confidence: high. surprises: the container initially lacked a runnable pnpm shim; Corepack resolved it outside the repository. follow-ups: none. </details>

coilyco-ops commented

2026-07-23 05:27:48 +00:00

Author

Member

WARDED_WORKFLOW: reservation-released

release details

Run finished with WARDED_WORKFLOW: done ✅.

ward container reap released container engineer-codex-eco-app-133 (--harness codex): the terminal outcome supersedes the reservation, so a later redispatch no longer needs --override-reservation.

— Codex, via ward agent

WARDED_WORKFLOW: reservation-released <details><summary>release details</summary> Run finished with `WARDED_WORKFLOW: done ✅`. `ward container reap` released container `engineer-codex-eco-app-133` (`--harness codex`): the terminal outcome supersedes the reservation, so a later redispatch no longer needs `--override-reservation`. </details>  — Codex, via `ward agent`

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-gaming/eco-app#133

No description provided.

Rows
Columns