Every other ward CI step should block behind the test job #999

Closed
opened 2026-07-10 09:51:51 +00:00 by coilysiren · 6 comments
Owner

The problem

I feel this should be obvious ...?

Proposed change

//

Alternatives considered

//

Before filing

  • I searched existing issues and this is not a duplicate.
  • This stays within ward's scope (the dev-verb gate / agent driver), not a personal-infra or downstream-repo verb.
### The problem I feel this should be obvious ...? ### Proposed change // ### Alternatives considered // ### Before filing - [x] I searched existing issues and this is not a duplicate. - [x] This stays within ward's scope (the dev-verb gate / agent driver), not a personal-infra or downstream-repo verb.
Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-claude-ward-999 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness claude (reserved 2026-07-10T17:00:02Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)
  • Resolved: coilyco-flight-deck/ward#999 · branch issue-999 · harness claude · workflow pull-requests-and-merge
  • Run: engineer-claude-ward-999 · ward v0.584.0 · dispatched 2026-07-10T17:00:02Z
  • Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0).

— Claude (she/her), via ward agent

<!-- ward-agent-reservation --> WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-claude-ward-999` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness claude` (reserved 2026-07-10T17:00:02Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#999` · branch `issue-999` · harness `claude` · workflow `pull-requests-and-merge` - **Run:** `engineer-claude-ward-999` · ward `v0.584.0` · dispatched `2026-07-10T17:00:02Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0). </details> </details> <!-- ward-agent-signature --> — Claude (she/her), via `ward agent`
Member

WARD-OUTCOME: merge-ready

details

workflow: pull-requests-and-merge; review summary: skipped - the in-container review gate was intentionally skipped by the ~/.ward/config.yaml default.

PR: #1035 (branch issue-999, carries closes #999). CI on the head commit is green (test / test success), origin/main (30701bad) is merged into the branch, and the PR reports mergeable. Merge is left to the director per the run authorization.

What changed: test.yml and release.yml were independent workflows on main pushes, so a push with failing tests still tagged and published a release. Forgejo Actions has no cross-workflow needs, so release.yml now opens with a test gate job (same vet/test/lint as test.yml, same container image, same Telegram alert convention) and release needs it; every other job already needs release, so tag, binaries, kdl tiers, tap, and scoop all block transitively.

Retrospective: the implementation felt straightforward once the dependency graph was mapped; the surprises were environmental. The container disk hit 100% and killed golangci-lint mid-typecheck (cleared go caches to recover), and the commit gate was blocked by pre-existing comment-discipline violations in cmd/ward/configsource.go (5-line comment block + dead docs/ward-specs.md ref) that somehow landed on main past the hooks - repaired in a separate commit on this branch, detail moved to docs/config-source.md. My own first attempt at the gate comment also violated the YAML-comments-above-header rule; the explanation now lives in the file header. Confidence: high - the graph was machine-verified (test -> release -> everything) and the gate job is a byte-for-byte copy of the proven test workflow steps.

Follow-ups worth a look: (1) how the configsource.go violations bypassed the commit hooks on main, and (2) a genuine main test failure now fires two Telegram alerts (one per workflow) - accepted for loudness, but dedupable if noisy.

This reservation can be released; the branch and PR are ready for the director's merge.

— Claude (she/her), via ward agent

WARD-OUTCOME: merge-ready <details><summary>details</summary> workflow: pull-requests-and-merge; review summary: skipped - the in-container review gate was intentionally skipped by the ~/.ward/config.yaml default. PR: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1035 (branch `issue-999`, carries `closes #999`). CI on the head commit is green (`test / test` success), `origin/main` (30701bad) is merged into the branch, and the PR reports mergeable. Merge is left to the director per the run authorization. What changed: `test.yml` and `release.yml` were independent workflows on `main` pushes, so a push with failing tests still tagged and published a release. Forgejo Actions has no cross-workflow `needs`, so `release.yml` now opens with a `test` gate job (same vet/test/lint as `test.yml`, same container image, same Telegram alert convention) and `release` needs it; every other job already needs `release`, so tag, binaries, kdl tiers, tap, and scoop all block transitively. Retrospective: the implementation felt straightforward once the dependency graph was mapped; the surprises were environmental. The container disk hit 100% and killed golangci-lint mid-typecheck (cleared go caches to recover), and the commit gate was blocked by pre-existing comment-discipline violations in `cmd/ward/configsource.go` (5-line comment block + dead `docs/ward-specs.md` ref) that somehow landed on `main` past the hooks - repaired in a separate commit on this branch, detail moved to `docs/config-source.md`. My own first attempt at the gate comment also violated the YAML-comments-above-header rule; the explanation now lives in the file header. Confidence: high - the graph was machine-verified (test -> release -> everything) and the gate job is a byte-for-byte copy of the proven test workflow steps. Follow-ups worth a look: (1) how the configsource.go violations bypassed the commit hooks on main, and (2) a genuine `main` test failure now fires two Telegram alerts (one per workflow) - accepted for loudness, but dedupable if noisy. This reservation can be released; the branch and PR are ready for the director's merge. </details> <!-- ward-agent-signature --> — Claude (she/her), via `ward agent`
Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-999 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-10T18:03:31Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)
  • Resolved: coilyco-flight-deck/ward#999 · branch issue-999 · harness codex · workflow pull-requests-and-merge
  • Run: engineer-codex-ward-999 · ward v0.584.0 · dispatched 2026-07-10T18:03:31Z
  • Comment thread: 1 included in the pre-flight read, 1 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0).

— Codex, via ward agent

<!-- ward-agent-reservation --> WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-999` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-10T18:03:31Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#999` · branch `issue-999` · harness `codex` · workflow `pull-requests-and-merge` - **Run:** `engineer-codex-ward-999` · ward `v0.584.0` · dispatched `2026-07-10T18:03:31Z` - **Comment thread:** 1 included in the pre-flight read, 1 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-10T17:10:26Z) - stripped: @coilyco-ops (2026-07-10T17:00:03Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.584.0). </details> </details> <!-- ward-agent-signature --> — Codex, via `ward agent`
Member

WARD-OUTCOME: merge-ready

details

workflow: pull-requests-and-merge; review summary: skipped - the in-container review gate was intentionally skipped by the ~/.ward/config.yaml default.
PR: #1035 is green and mergeable on branch issue-999.
Retrospective: the implementation felt straightforward once the stale-base merge was done and the configsource conflict was collapsed.
Confidence: high.
Follow-ups: none.

WARD-OUTCOME: merge-ready <details><summary>details</summary> workflow: pull-requests-and-merge; review summary: skipped - the in-container review gate was intentionally skipped by the ~/.ward/config.yaml default. PR: #1035 is green and mergeable on branch `issue-999`. Retrospective: the implementation felt straightforward once the stale-base merge was done and the configsource conflict was collapsed. Confidence: high. Follow-ups: none. </details>
Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-999 on host KAI-DESKTOP-TOWER.

Reserved by ward agent --harness codex (reserved 2026-07-11T01:20:47Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)
  • Resolved: coilyco-flight-deck/ward#999 · branch issue-999 · harness codex · workflow pull-requests-and-merge
  • Run: engineer-codex-ward-999 · ward v0.605.0 · dispatched 2026-07-11T01:20:47Z
  • Comment thread: 2 included in the pre-flight read, 2 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.605.0).

— Codex, via ward agent

<!-- ward-agent-reservation --> WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-999` on host `KAI-DESKTOP-TOWER`. Reserved by `ward agent --harness codex` (reserved 2026-07-11T01:20:47Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#999` · branch `issue-999` · harness `codex` · workflow `pull-requests-and-merge` - **Run:** `engineer-codex-ward-999` · ward `v0.605.0` · dispatched `2026-07-11T01:20:47Z` - **Comment thread:** 2 included in the pre-flight read, 2 stripped (ward's own automated comments). - included: @coilyco-ops (2026-07-10T17:10:26Z), @coilyco-ops (2026-07-10T18:11:11Z) - stripped: @coilyco-ops (2026-07-10T17:00:03Z), @coilyco-ops (2026-07-10T18:03:31Z) Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.605.0). </details> </details> <!-- ward-agent-signature --> — Codex, via `ward agent`
Member

WARD-OUTCOME: submitted

details

workflow: pull-request-and-merge; review summary: skipped - the in-container review gate was intentionally skipped because the temporary ward default pending brokered QA.
Retrospective: the merge was mostly mechanical. The only snag was a stale conflict snapshot and a dead bundle-constant detour, both cleared locally before push.
Confidence: high.
Surprises: Forgejo lagged on the PR conflict banner even after the merge commit pushed; the API was the reliable source of truth.
Follow-ups: none.

WARD-OUTCOME: submitted <details><summary>details</summary> workflow: pull-request-and-merge; review summary: skipped - the in-container review gate was intentionally skipped because the temporary ward default pending brokered QA. Retrospective: the merge was mostly mechanical. The only snag was a stale conflict snapshot and a dead bundle-constant detour, both cleared locally before push. Confidence: high. Surprises: Forgejo lagged on the PR conflict banner even after the merge commit pushed; the API was the reliable source of truth. Follow-ups: none. </details>
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/ward#999
No description provided.