Temporarily disable in-container review gate by default in code #797

New issue

Closed

opened 2026-07-09 09:23:57 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-09 09:23:57 +00:00

Member

Problem

The host-local ~/.ward/config.yaml kill switch now disables the in-container review gate for new dispatches on this host:

agent:
  review:
    skip:
      - role:engineer

That is useful immediately, but it is host-local. While brokered QA is being designed and review launch regressions are being repaired, ward should also carry a short-lived hardcoded emergency flip so newly launched engineers do not depend on in-container review by default across surfaces/hosts.

Do

Add a temporary hardcoded default that disables the in-container review gate for engineer dispatches.
Keep explicit skip wording clear in the seed and final outcome. It should say review was disabled by the temporary ward default, not imply CI or QA passed.
Preserve the ability to run ward agent review manually for diagnostics.
Prefer a small named function/constant with a TODO/reference to the brokered QA follow-up rather than scattering conditionals.
Add or update tests proving default engineer seeds omit the in-container review clause while explicit/manual review command behavior remains available.
Update docs/features only if the user-visible default changes enough to need it. This likely does need a short note in docs/dispatch-review.md and docs/FEATURES.md saying the in-container gate is temporarily disabled by default pending brokered QA.

Acceptance

A normal warded engineer owner/repo#N seed does not require ward agent review before landing.
The final outcome review summary records an intentional temporary skip.
Existing --skip-review / config skip behavior still works.
ward agent review remains callable directly.
ward exec test passes.

Context

Related issues:

ward#790 - no-reviewer block wording still said advisory-only.
ward#791 - Codex reviewer launch probe failed before same-family review could run.
ward#792 - design brokered QA roles to replace/deprecate in-container review.
ward#795 - advisor/ref dispatch hang from a read-only surface.

Dispatch note

Dispatch with --skip-review; this issue is about disabling the review gate and must not be blocked by it.

## Problem The host-local `~/.ward/config.yaml` kill switch now disables the in-container review gate for new dispatches on this host: ```yaml agent: review: skip: - role:engineer ``` That is useful immediately, but it is host-local. While brokered QA is being designed and review launch regressions are being repaired, ward should also carry a short-lived hardcoded emergency flip so newly launched engineers do not depend on in-container review by default across surfaces/hosts. ## Do * Add a temporary hardcoded default that disables the in-container review gate for engineer dispatches. * Keep explicit skip wording clear in the seed and final outcome. It should say review was disabled by the temporary ward default, not imply CI or QA passed. * Preserve the ability to run `ward agent review` manually for diagnostics. * Prefer a small named function/constant with a TODO/reference to the brokered QA follow-up rather than scattering conditionals. * Add or update tests proving default engineer seeds omit the in-container review clause while explicit/manual review command behavior remains available. * Update docs/features only if the user-visible default changes enough to need it. This likely does need a short note in `docs/dispatch-review.md` and `docs/FEATURES.md` saying the in-container gate is temporarily disabled by default pending brokered QA. ## Acceptance * A normal `warded engineer owner/repo#N` seed does not require `ward agent review` before landing. * The final outcome review summary records an intentional temporary skip. * Existing `--skip-review` / config skip behavior still works. * `ward agent review` remains callable directly. * `ward exec test` passes. ## Context Related issues: * ward#790 - no-reviewer block wording still said advisory-only. * ward#791 - Codex reviewer launch probe failed before same-family review could run. * ward#792 - design brokered QA roles to replace/deprecate in-container review. * ward#795 - advisor/ref dispatch hang from a read-only surface. ## Dispatch note Dispatch with `--skip-review`; this issue is about disabling the review gate and must not be blocked by it.

coilyco-ops commented

2026-07-09 09:24:05 +00:00

Author

Member

🔒 Reserved by ward agent --harness codex — container engineer-codex-ward-797 on host kais-macbook-pro-2.local is carrying this issue (reserved 2026-07-09T09:24:03Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL); --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh — that is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#797 · branch issue-797 · harness codex · workflow pr
Run: engineer-codex-ward-797 · ward v0.488.0 · dispatched 2026-07-09T09:24:03Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.488.0).

— Codex, via ward agent

🔒 Reserved by `ward agent --harness codex` — container `engineer-codex-ward-797` on host `kais-macbook-pro-2.local` is carrying this issue (reserved 2026-07-09T09:24:03Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL); `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh** — that is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#797` · branch `issue-797` · harness `codex` · workflow `pr` - **Run:** `engineer-codex-ward-797` · ward `v0.488.0` · dispatched `2026-07-09T09:24:03Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.488.0). </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-09 09:32:39 +00:00

Temporarily disable in-container review gate by default in code #799

coilyco-ops commented

2026-07-09 09:38:22 +00:00

Author

Member

The work was straightforward once the doc split was done, though golangci-lint surfaced a couple of unrelated workflow-helper warnings that needed cleanup before the PR could go green. Confidence is high. The only rough edge is that the temporary default is still a stopgap, so brokered QA should own removing it later.

WARD-OUTCOME: done - disabled engineer review gate by temporary ward default workflow: pull-request; review summary: skipped: the temporary ward default pending brokered QA; dispatched with --skip-review The work was straightforward once the doc split was done, though golangci-lint surfaced a couple of unrelated workflow-helper warnings that needed cleanup before the PR could go green. Confidence is high. The only rough edge is that the temporary default is still a stopgap, so brokered QA should own removing it later.

coilyco-ops closed this issue

2026-07-09 15:46:40 +00:00