TestAgentWorkflowPrecedence is stale against the pull-request-and-merge default #1652

Closed

opened 2026-08-09 03:04:18 +00:00 by coilyco-ops · 1 comment

coilyco-ops commented

2026-08-09 03:04:18 +00:00

Owner

Problem

TestAgentWorkflowPrecedence fails on a pristine main at 573b53b ("chore(ward): declare the pull-request-and-merge landing policy"). It is not flaky and it is not environment-dependent - it fails in 0.00s:

--- FAIL: TestAgentWorkflowPrecedence (0.00s)
    agent_workflow_test.go:386: default workflow = "pull-request-and-merge", want merge-remote-main
    agent_workflow_test.go:394: repo workflow = "pull-request-and-merge", want baked merge-remote-main

The test still asserts the old merge-remote-main default. The commit that declared pull-request-and-merge changed the behavior without updating the assertions, so go test ./cmd/ward/ has been red on main since.

Evidence

Verified against a clean worktree at 573b53b with no local modifications, so it is independent of any in-flight branch. Found while running the suite for remove-format-exec-gate-refusal; that branch does not touch agent-workflow code and reproduces the identical failure.

Fix

Update the two assertions in cmd/ward/agent_workflow_test.go to expect pull-request-and-merge, or confirm the declared default is wrong and correct the source instead. Worth checking whether the same commit left other workflow assertions stale.

Note

go test ./... also hits the 10-minute default timeout in github.com/coilyco-flight-deck/ward/scripts. That is a separate observation, not covered by this issue.

## Problem `TestAgentWorkflowPrecedence` fails on a pristine `main` at `573b53b` ("chore(ward): declare the pull-request-and-merge landing policy"). It is not flaky and it is not environment-dependent - it fails in 0.00s: ``` --- FAIL: TestAgentWorkflowPrecedence (0.00s) agent_workflow_test.go:386: default workflow = "pull-request-and-merge", want merge-remote-main agent_workflow_test.go:394: repo workflow = "pull-request-and-merge", want baked merge-remote-main ``` The test still asserts the old `merge-remote-main` default. The commit that declared `pull-request-and-merge` changed the behavior without updating the assertions, so `go test ./cmd/ward/` has been red on `main` since. ## Evidence Verified against a clean worktree at `573b53b` with no local modifications, so it is independent of any in-flight branch. Found while running the suite for `remove-format-exec-gate-refusal`; that branch does not touch agent-workflow code and reproduces the identical failure. ## Fix Update the two assertions in `cmd/ward/agent_workflow_test.go` to expect `pull-request-and-merge`, or confirm the declared default is wrong and correct the source instead. Worth checking whether the same commit left other workflow assertions stale. ## Note `go test ./...` also hits the 10-minute default timeout in `github.com/coilyco-flight-deck/ward/scripts`. That is a separate observation, not covered by this issue.

coilyco-ops commented

2026-08-09 03:23:33 +00:00

Author

Owner

Still reproduces, and still unrelated to the branch that surfaced it.

Re-confirmed at 05702831 on remove-format-exec-gate-refusal. That branch now rewrites the exec gate and its tests substantially, and TestAgentWorkflowPrecedence fails identically before and after, in 0.00s, with the same two assertions:

agent_workflow_test.go:386: default workflow = "pull-request-and-merge", want merge-remote-main
agent_workflow_test.go:394: repo workflow = "pull-request-and-merge", want baked merge-remote-main

Worth noting for anyone reviewing that branch: CI on it will be red for this reason alone, not for anything the branch changed.

Still reproduces, and still unrelated to the branch that surfaced it. Re-confirmed at `05702831` on `remove-format-exec-gate-refusal`. That branch now rewrites the exec gate and its tests substantially, and `TestAgentWorkflowPrecedence` fails identically before and after, in 0.00s, with the same two assertions: ``` agent_workflow_test.go:386: default workflow = "pull-request-and-merge", want merge-remote-main agent_workflow_test.go:394: repo workflow = "pull-request-and-merge", want baked merge-remote-main ``` Worth noting for anyone reviewing that branch: CI on it will be red for this reason alone, not for anything the branch changed.

coilyco-ops referenced this issue from a commit

2026-08-09 04:15:11 +00:00

fix(ward): make the agent-workflow precedence test hermetic

coilyco-ops closed this issue

2026-08-09 04:15:11 +00:00

Commenting is not possible because the repository is archived.

No milestone

No project

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-flight-deck/ward#1652

No description provided.

Rows
Columns