coilyco-flight-deck/ward

Watch

Close fail-open gaps in actor admission PR 1583 #1584

New issue

Closed

opened 2026-07-28 03:38:38 +00:00 by coilyco-ops · 3 comments

coilyco-ops commented

2026-07-28 03:38:38 +00:00

Member

Parent goal: #1574. Existing implementation branch and PR: #1583 at reviewed head 107267e7bf. This issue owns the blocking corrections from the review comment on that PR. Required changes: missing or blank issue author must require approval and never admit raw content; incomplete approval records must be rejected unless content hash, issue update time, issue author, approving actor, approval time, and selected comment identity are present and match; any new untrusted comment after approval must invalidate the snapshot before triage, dispatch, prompt construction, QA, or merge; execution must receive only the approved comment set, never the full current thread after approval; the approval action must bind the audit record to an authenticated trusted collaborator rather than accepting an unverifiable free-text identity. Add adversarial tests for missing author, incomplete fields, later untrusted comment, forged marker, and mutation before merge. Keep the #1565 host-context test change linked or split. Update the existing PR branch, do not merge it, and keep containment active until an exact-head independent review passes.

Parent goal: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/issues/1574. Existing implementation branch and PR: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1583 at reviewed head 107267e7bfa364a6acdb42633dc3135e364dd502. This issue owns the blocking corrections from the review comment on that PR. Required changes: missing or blank issue author must require approval and never admit raw content; incomplete approval records must be rejected unless content hash, issue update time, issue author, approving actor, approval time, and selected comment identity are present and match; any new untrusted comment after approval must invalidate the snapshot before triage, dispatch, prompt construction, QA, or merge; execution must receive only the approved comment set, never the full current thread after approval; the approval action must bind the audit record to an authenticated trusted collaborator rather than accepting an unverifiable free-text identity. Add adversarial tests for missing author, incomplete fields, later untrusted comment, forged marker, and mutation before merge. Keep the #1565 host-context test change linked or split. Update the existing PR branch, do not merge it, and keep containment active until an exact-head independent review passes.

coilyco-ops added the

priority

label

2026-07-28 03:38:38 +00:00

coilyco-ops referenced this issue

2026-07-28 03:40:50 +00:00

Add actor-aware admission for external Forgejo issues and comments #1583

coilyco-ops referenced this issue

2026-07-28 03:48:04 +00:00

Stabilize Ward for safe autonomous burndown and verified releases #1574

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-28 04:12:46 +00:00

Close fail-open gaps in actor admission PR 1583 #1585

coilyco-ops referenced this issue

2026-07-28 04:17:25 +00:00

Stop engineer prompts from iterating against live CI #1587

coilyco-ops commented

2026-07-28 04:24:05 +00:00

Author

Member

WARD-WORKFLOW: #1585

details

workflow: pull-request; review summary: skipped (in-container review gate skipped because temporary ward default pending brokered QA)

The hard parts were mostly gate-hardening and fixture cleanup.

confidence: high
surprises: Forgejo briefly closed the PR state; one host-GOOS test had to follow the injected host identity.
follow-ups: watch PR 1585 for merge readiness.

WARD-WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1585 <details><summary>details</summary> workflow: pull-request; review summary: skipped (in-container review gate skipped because temporary ward default pending brokered QA) The hard parts were mostly gate-hardening and fixture cleanup. confidence: high surprises: Forgejo briefly closed the PR state; one host-GOOS test had to follow the injected host identity. follow-ups: watch PR 1585 for merge readiness. </details>

coilyco-ops commented

2026-07-28 04:24:13 +00:00

Author

Member

WARD-WORKFLOW: failed ❌

reap details

ward container reap found a submitted pull request for this launched run, but Forgejo later closed it without merging.

Container: engineer-codex-ward-1584
Workflow: pull-request
PR: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1585
Recovery: reopen the PR or cut a fresh run, then redispatch from the current base.

— Codex, via ward agent

WARD-WORKFLOW: failed ❌ <details><summary>reap details</summary> `ward container reap` found a submitted pull request for this launched run, but Forgejo later closed it without merging. - **Container:** `engineer-codex-ward-1584` - **Workflow:** `pull-request` - **PR:** `https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1585` - **Recovery:** reopen the PR or cut a fresh run, then redispatch from the current base. </details>  — Codex, via `ward agent`

coilyco-ops commented

2026-07-29 02:56:54 +00:00

Author

Member

Superseded by the complete replacement contract in Ward issue 1586. PR 1583 and corrective PR 1585 were both closed unmerged after review found additional fail-open authority, snapshot, prompt-admission, and machine-state provenance gaps. Issue 1586 incorporates this issue's requirements and the broader reviewed replacement contract. Closing this intermediate correction tracker to keep one active implementation target.

coilyco-ops closed this issue

2026-07-29 02:56:56 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-flight-deck/ward#1584

No description provided.

Rows
Columns