Exclude closed completed issues from active dispatch-health failures #1576

New issue

Closed

opened 2026-07-28 02:45:16 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-28 02:45:16 +00:00

Member

Outcome

ward agent dispatch-health must report current actionable lifecycle state. A closed issue with historical blocked or salvage markers must not remain an active failure after repository and tracker evidence show the work is complete.

Parent goal: #1574

Reproduction

On 2026-07-27, the goal run closed these completed issues with commit-level evidence:

#1443
#1526

Both issues had landed WARD-WORKFLOW: done records followed by false salvage or blocked records after their commits were already on main.

A fresh command after closure returned:

dispatch-health: queued=2 ... failed=3 running=0 ...
coilyco-flight-deck/ward#1443 -> blocked (issue is closed)
coilyco-flight-deck/ward#1526 -> blocked (issue is closed)

The command observes that each issue is closed, but it still promotes those records into the active failed count and signal.

Required behavior

Ward must exclude closed completed issues from active queued, failed, held, submitted, merge-ready, running, and cleanup-needed health counts.
Ward may retain historical terminal evidence in an explicitly historical field or diagnostic view, but that history must not trigger the active failed signal.
Ward must reconcile a stale blocked or salvage marker against live issue state before it aggregates health.
Ward must preserve real failures for open issues and closed-unmerged pull requests that still require recovery.
The director queue and dispatch-health surfaces must describe the same current lifecycle state for an issue, even when they expose different overall scopes.

Acceptance criteria

A closed issue with an older blocked marker and a newer or older done marker contributes zero active failures.
A closed issue whose commit already landed contributes zero active failures even when a false salvage comment is newest.
An open issue with the same blocked history remains failed or blocked.
A closed-unmerged pull request that requires recovery remains visible in the appropriate recovery state.
Re-running dispatch-health after closing the completed fixtures removes the active failed signal without deleting historical comments.
Ward's repository-declared vet, lint, test, and pre-commit validation passes.
Current Ward dispatch-health no longer reports #1443 or #1526 as active failures.

docs/FEATURES.md does not need a bugfix-only update.

Codex, via advisor surface

## Outcome `ward agent dispatch-health` must report current actionable lifecycle state. A closed issue with historical blocked or salvage markers must not remain an active failure after repository and tracker evidence show the work is complete. Parent goal: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/issues/1574 ## Reproduction On 2026-07-27, the goal run closed these completed issues with commit-level evidence: * https://forgejo.coilysiren.me/coilyco-flight-deck/ward/issues/1443 * https://forgejo.coilysiren.me/coilyco-flight-deck/ward/issues/1526 Both issues had landed `WARD-WORKFLOW: done` records followed by false salvage or blocked records after their commits were already on `main`. A fresh command after closure returned: ```text dispatch-health: queued=2 ... failed=3 running=0 ... coilyco-flight-deck/ward#1443 -> blocked (issue is closed) coilyco-flight-deck/ward#1526 -> blocked (issue is closed) ``` The command observes that each issue is closed, but it still promotes those records into the active failed count and signal. ## Required behavior * Ward must exclude closed completed issues from active queued, failed, held, submitted, merge-ready, running, and cleanup-needed health counts. * Ward may retain historical terminal evidence in an explicitly historical field or diagnostic view, but that history must not trigger the active `failed` signal. * Ward must reconcile a stale blocked or salvage marker against live issue state before it aggregates health. * Ward must preserve real failures for open issues and closed-unmerged pull requests that still require recovery. * The director queue and dispatch-health surfaces must describe the same current lifecycle state for an issue, even when they expose different overall scopes. ## Acceptance criteria * A closed issue with an older blocked marker and a newer or older done marker contributes zero active failures. * A closed issue whose commit already landed contributes zero active failures even when a false salvage comment is newest. * An open issue with the same blocked history remains failed or blocked. * A closed-unmerged pull request that requires recovery remains visible in the appropriate recovery state. * Re-running dispatch-health after closing the completed fixtures removes the active failed signal without deleting historical comments. * Ward's repository-declared vet, lint, test, and pre-commit validation passes. * Current Ward dispatch-health no longer reports https://forgejo.coilysiren.me/coilyco-flight-deck/ward/issues/1443 or https://forgejo.coilysiren.me/coilyco-flight-deck/ward/issues/1526 as active failures. `docs/FEATURES.md` does not need a bugfix-only update.  Codex, via advisor surface

coilyco-ops referenced this issue

2026-07-28 02:47:45 +00:00

Stabilize Ward for safe autonomous burndown and verified releases #1574

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-28 03:03:35 +00:00

Exclude closed completed issues from active dispatch-health failures #1579

coilyco-ops commented

2026-07-28 03:05:09 +00:00

Author

Member

WARD-WORKFLOW: #1579

details

workflow: pull-request; review summary: skipped (in-container review gate intentionally skipped because temporary ward default pending brokered QA)
implemented: dispatch-health now filters closed-complete issue refs out of active counts after checking live issue state
retrospective: the live filter was the clean fix; the only wrinkle was the container exporting WARD_HOST_GOOS=windows
confidence: high
surprises: WARD_HOST_GOOS had to be forced to linux for the repo test suite
follow-ups: none

WARD-WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1579 <details><summary>details</summary> workflow: pull-request; review summary: skipped (in-container review gate intentionally skipped because temporary ward default pending brokered QA) implemented: dispatch-health now filters closed-complete issue refs out of active counts after checking live issue state retrospective: the live filter was the clean fix; the only wrinkle was the container exporting WARD_HOST_GOOS=windows confidence: high surprises: WARD_HOST_GOOS had to be forced to linux for the repo test suite follow-ups: none </details>

coilyco-ops commented

2026-07-28 03:05:15 +00:00

Author

Member

WARD-WORKFLOW: reservation-released

release details

Run finished with WARD-WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1579.

ward container reap released container engineer-codex-ward-1576 (--harness codex): the terminal outcome supersedes the reservation, so a later redispatch no longer needs --override-reservation.

Outcome summary: #1579

— Codex, via ward agent

WARD-WORKFLOW: reservation-released <details><summary>release details</summary> Run finished with `WARD-WORKFLOW: https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1579`. `ward container reap` released container `engineer-codex-ward-1576` (`--harness codex`): the terminal outcome supersedes the reservation, so a later redispatch no longer needs `--override-reservation`. **Outcome summary:** https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1579 </details>  — Codex, via `ward agent`