coilyco-flight-deck/ward

Watch

Reaper shouldnt create salvage PR when the PR would be empty #1561

New issue

Closed

opened 2026-07-25 08:53:03 +00:00 by coilysiren · 3 comments

coilysiren commented

2026-07-25 08:53:03 +00:00

Owner

No description provided.

coilysiren commented

2026-07-25 08:53:55 +00:00

Author

Owner

Example #1559

Example https://forgejo.coilysiren.me/coilyco-flight-deck/ward/pulls/1559

coilyco-ops referenced this issue

2026-07-25 23:24:11 +00:00

Brokered launch should create missing launch-staging directory #1563

coilyco-ops referenced this issue

2026-07-25 23:54:32 +00:00

Copy file bind sources correctly during brokered dispatch #1566

coilyco-ops referenced this issue from a commit

2026-07-26 00:32:05 +00:00

fix: skip empty salvage pull requests

coilyco-ops closed this issue

2026-07-26 00:32:05 +00:00

coilyco-ops commented

2026-07-26 00:37:40 +00:00

Member

WARD-WORKFLOW: done ✅

details

workflow: merge-remote-main; review summary: skipped - the in-container review gate was intentionally skipped because the temporary ward default is pending brokered QA.

implemented: landed 87677ee2 on main. The reaper now refreshes origin/main, detects salvage branches with no PR diff, and keeps the salvage notice branch-only instead of creating a zero-file PR.

validation: focused reaper tests passed; commit hooks passed including golangci-lint. ward exec test ran but failed on existing TestBuildUpPlanTailnet host-net expectation, unrelated to this change. Post-push Actions check: promote triggered release.yml #2438 for 87677ee2; release was waiting when checked.

felt: small, localized fix once the PR #1559 shape made the bug obvious.

confidence: high for the empty-PR guard; medium for release completion because it was still queued/running at handoff.

surprises: installed ward v0.812.0 no longer had the documented ward ops forgejo tasks surface, so I used the Forgejo Actions API fallback.

follow-ups: consider ignoring or otherwise hiding .ward-run-provenance.json from normal git status without breaking the reaper proof path.

WARD-WORKFLOW: done ✅ <details><summary>details</summary> workflow: merge-remote-main; review summary: skipped - the in-container review gate was intentionally skipped because the temporary ward default is pending brokered QA. implemented: landed 87677ee2 on main. The reaper now refreshes origin/main, detects salvage branches with no PR diff, and keeps the salvage notice branch-only instead of creating a zero-file PR. validation: focused reaper tests passed; commit hooks passed including golangci-lint. `ward exec test` ran but failed on existing `TestBuildUpPlanTailnet` host-net expectation, unrelated to this change. Post-push Actions check: promote triggered release.yml #2438 for 87677ee2; release was waiting when checked. felt: small, localized fix once the PR #1559 shape made the bug obvious. confidence: high for the empty-PR guard; medium for release completion because it was still queued/running at handoff. surprises: installed ward v0.812.0 no longer had the documented `ward ops forgejo tasks` surface, so I used the Forgejo Actions API fallback. follow-ups: consider ignoring or otherwise hiding `.ward-run-provenance.json` from normal `git status` without breaking the reaper proof path. </details>

coilyco-ops commented

2026-07-26 00:37:49 +00:00

Member

WARD-WORKFLOW: reservation-released

release details

Run finished with WARD-WORKFLOW: done ✅.

ward container reap released container engineer-codex-ward-1561 (--harness codex): the terminal outcome supersedes the reservation, so a later redispatch no longer needs --override-reservation.

— Codex, via ward agent

WARD-WORKFLOW: reservation-released <details><summary>release details</summary> Run finished with `WARD-WORKFLOW: done ✅`. `ward container reap` released container `engineer-codex-ward-1561` (`--harness codex`): the terminal outcome supersedes the reservation, so a later redispatch no longer needs `--override-reservation`. </details>  — Codex, via `ward agent`

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-flight-deck/ward#1561

No description provided.

Rows
Columns