CI: remove stale deployment config assumptions from tests #1507

Closed

opened 2026-07-22 16:10:11 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-07-22 16:10:11 +00:00

Owner

Symptom

The promote workflow has failed in the Go test step since run 2349 and remains red through run 2351.

Root cause

The deployment-config ownership changes intentionally made Ward ship an empty substrate roster and require an explicit Goose model. Four older test fixtures still assumed the prior embedded values:

TestResolveCatalogContextReposFromClone expected cli-guard to be present in the substrate roster.
TestRegistryConfigComposersWrite omitted the required Goose model.
TestComposeAgentContainerPerMode omitted the required Goose model.
TestRunContainerBootstrapGooseNoSessionExitsAndReaps omitted the required Goose model.

Fix

Remove the deployment-specific substrate entry from the clone-resolution fixture. Supply a neutral configured-model input in tests that exercise Goose behavior. Keep substrate de-duplication covered by the pure resolver test with an injected set.

Done condition

Full Go test suite passes with host commit signing disabled for fixture repositories.
Vet, golangci-lint, build, workflow lint, and diff checks pass.
The next promote run reaches green.

## Symptom The `promote` workflow has failed in the Go test step since run 2349 and remains red through run 2351. ## Root cause The deployment-config ownership changes intentionally made Ward ship an empty substrate roster and require an explicit Goose model. Four older test fixtures still assumed the prior embedded values: * `TestResolveCatalogContextReposFromClone` expected `cli-guard` to be present in the substrate roster. * `TestRegistryConfigComposersWrite` omitted the required Goose model. * `TestComposeAgentContainerPerMode` omitted the required Goose model. * `TestRunContainerBootstrapGooseNoSessionExitsAndReaps` omitted the required Goose model. ## Fix Remove the deployment-specific substrate entry from the clone-resolution fixture. Supply a neutral `configured-model` input in tests that exercise Goose behavior. Keep substrate de-duplication covered by the pure resolver test with an injected set. ## Done condition * Full Go test suite passes with host commit signing disabled for fixture repositories. * Vet, golangci-lint, build, workflow lint, and diff checks pass. * The next `promote` run reaches green.

coilyco-ops referenced this issue from a commit

2026-07-22 16:14:39 +00:00

fix(ci): align tests with deployment config (closes #1507)

coilyco-ops closed this issue

2026-07-22 16:14:39 +00:00

Commenting is not possible because the repository is archived.

No milestone

No project

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-flight-deck/ward#1507

No description provided.

Rows
Columns