Document manual stale reservation cleanup #1218

Merged

coilysiren merged 1 commit from issue-1198 into main

2026-07-14 00:07:35 +00:00

coilyco-ops commented

2026-07-13 23:56:59 +00:00

Member

This documents the manual stale reservation cleanup workaround for ghost container starting records that still count toward capacity.

explains how to identify stale reservations from ward agent list --json
shows how to find and delete the targeted Forgejo reservation comment
points the repo-limit error and troubleshooting docs at the cleanup path
keeps the distinction clear between issue-comment cleanup and host-side file deletion

Tests:

go test ./cmd/ward -run 'TestEngineerContainerLimit|TestEngineerContainerLimitOverrideCapacity|TestFormatAgentListCapacityNotesUnavailableSource' -count=1
pre-commit run --all-files

closes #1198
ward.workflow: pull-request-and-merge

This documents the manual stale reservation cleanup workaround for ghost `container starting` records that still count toward capacity. - explains how to identify stale reservations from `ward agent list --json` - shows how to find and delete the targeted Forgejo reservation comment - points the repo-limit error and troubleshooting docs at the cleanup path - keeps the distinction clear between issue-comment cleanup and host-side file deletion Tests: - `go test ./cmd/ward -run 'TestEngineerContainerLimit|TestEngineerContainerLimitOverrideCapacity|TestFormatAgentListCapacityNotesUnavailableSource' -count=1` - `pre-commit run --all-files` closes #1198 ward.workflow: pull-request-and-merge

coilyco-ops added 1 commit

2026-07-13 23:56:59 +00:00

docs: document stale reservation cleanup

test / test (pull_request) Successful in 37s

Details

b86d428a96

coilyco-ops commented

2026-07-13 23:58:38 +00:00

Author

Member

WARDED_WORKFLOW review-note

verdict: block
confidence: high
summary: PR 1218 documents the right area, but it is not safe to land as written. The docs contradict the verified cleanup flow and the diff has a whitespace gate failure.
findings:

severity: medium
file: docs/troubleshooting.md
line: n/a
problem: The new guidance says an already terminal issue means stale reservation cleanup is not the fix.
impact: That is backwards for the failure mode this doc is supposed to cover. The 1200 and 1202 repairs were terminal, but their stale reservation comments and host reservation files still had to be cleared to restore accurate capacity.
severity: medium
file: docs/agent-stale-reservation-cleanup.md
line: n/a
problem: The cleanup doc says this is issue-comment cleanup, not host-side file deletion.
impact: The reliable manual workaround needs both sides when local cache is stale: remove the durable reservation marker and remove matching host .ward/agent-reservations/<owner>-<repo>-issue-<n>.json plus .lock files after verifying no visible engineer is running.
severity: low
file: docs/agent-stale-reservation-cleanup.md
line: 44
problem: git diff --check reports a new blank line at EOF.
impact: The branch should not pass the local hygiene gate as written, even though CI later reported success.
conclusion: Blocked. Repair the docs so terminal-but-stale reservations are explicitly in scope, include the host reservation file cleanup step with the same safety checks, remove WARD-OUTCOME: submitted as a recommended terminal marker in favor of PR-link outcomes, and fix the whitespace failure before re-requesting merge.

WARDED_WORKFLOW review-note verdict: block confidence: high summary: PR 1218 documents the right area, but it is not safe to land as written. The docs contradict the verified cleanup flow and the diff has a whitespace gate failure. findings: - severity: medium file: docs/troubleshooting.md line: n/a problem: The new guidance says an already terminal issue means stale reservation cleanup is not the fix. impact: That is backwards for the failure mode this doc is supposed to cover. The 1200 and 1202 repairs were terminal, but their stale reservation comments and host reservation files still had to be cleared to restore accurate capacity. - severity: medium file: docs/agent-stale-reservation-cleanup.md line: n/a problem: The cleanup doc says this is issue-comment cleanup, not host-side file deletion. impact: The reliable manual workaround needs both sides when local cache is stale: remove the durable reservation marker and remove matching host `.ward/agent-reservations/<owner>-<repo>-issue-<n>.json` plus `.lock` files after verifying no visible engineer is running. - severity: low file: docs/agent-stale-reservation-cleanup.md line: 44 problem: `git diff --check` reports a new blank line at EOF. impact: The branch should not pass the local hygiene gate as written, even though CI later reported success. conclusion: Blocked. Repair the docs so terminal-but-stale reservations are explicitly in scope, include the host reservation file cleanup step with the same safety checks, remove `WARD-OUTCOME: submitted` as a recommended terminal marker in favor of PR-link outcomes, and fix the whitespace failure before re-requesting merge.

coilyco-ops referenced this pull request

2026-07-13 23:58:49 +00:00

Document manual stale reservation cleanup #1198