Make stop --print honest for ghost launch records #1216

Merged

coilysiren merged 2 commits from issue-1200 into main

2026-07-13 23:56:24 +00:00

coilyco-ops commented

2026-07-13 23:44:43 +00:00

Member

This change makes ward agent stop --print use the same stop verdict as the live stop path. Ghost launch records now fail with an explicit not-stoppable message that points at ward agent reap or stale-reservation cleanup, while a visible running engineer still prints the exact target.

--print now asks the host broker for a preview stop verdict instead of only resolving the ref.
The broker now treats reservation-only ghost records as not stoppable.
Tests cover live engineers, ghost reservations, and unknown refs.
Validation: go test ./cmd/ward and pre-commit run --all-files.

closes #1200
ward.workflow: pull-request-and-merge

This change makes `ward agent stop --print` use the same stop verdict as the live stop path. Ghost launch records now fail with an explicit not-stoppable message that points at `ward agent reap` or stale-reservation cleanup, while a visible running engineer still prints the exact target. - `--print` now asks the host broker for a preview stop verdict instead of only resolving the ref. - The broker now treats reservation-only ghost records as not stoppable. - Tests cover live engineers, ghost reservations, and unknown refs. - Validation: `go test ./cmd/ward` and `pre-commit run --all-files`. closes #1200 ward.workflow: pull-request-and-merge

coilyco-ops added 1 commit

2026-07-13 23:44:43 +00:00

fix stop preview honesty for ghost records

test / test (pull_request) Successful in 56s

Details

7167475aaa

coilyco-ops commented

2026-07-13 23:46:58 +00:00

Author

Member

WARDED_WORKFLOW review-note

verdict: block
confidence: high
summary: The stop/print implementation matches ward#1200: preview stop now uses the broker stoppability path, ghost reservations are explicitly rejected, and tests cover visible engineers, ghost reservations, and unknown refs. The PR is blocked because Forgejo reports it is not mergeable against current main.
findings:

severity: medium
file: n/a
line: n/a
problem: PR 1216 is green but mergeable=false; its base is behind current main after PR 1214 merged.
impact: The director cannot merge the PR as submitted, so the engineer has not carried the work to a fully mergeable landed state.
conclusion: Review blocks PR 1216 only on mergeability. The implementation satisfies the issue contract, but the branch must be rebased or merged with current main and pushed back green before the director merge lane can land it.

WARDED_WORKFLOW review-note verdict: block confidence: high summary: The stop/print implementation matches ward#1200: preview stop now uses the broker stoppability path, ghost reservations are explicitly rejected, and tests cover visible engineers, ghost reservations, and unknown refs. The PR is blocked because Forgejo reports it is not mergeable against current main. findings: - severity: medium file: n/a line: n/a problem: PR 1216 is green but `mergeable=false`; its base is behind current main after PR 1214 merged. impact: The director cannot merge the PR as submitted, so the engineer has not carried the work to a fully mergeable landed state. conclusion: Review blocks PR 1216 only on mergeability. The implementation satisfies the issue contract, but the branch must be rebased or merged with current main and pushed back green before the director merge lane can land it.

coilyco-ops referenced this pull request

2026-07-13 23:47:14 +00:00

Make stop --print honest for ghost launch records #1200

coilyco-ops referenced this pull request

2026-07-13 23:47:23 +00:00

Make stop --print honest for ghost launch records #1200

coilyco-ops added 1 commit

2026-07-13 23:52:16 +00:00

Merge origin/main into issue-1200

test / test (pull_request) Successful in 1m22s

Details

7c55de2e31