Reaper commits bypass the pre-commit gate and can land a red tree on main #1147

New issue

Closed

opened 2026-07-13 03:21:59 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-13 03:21:59 +00:00

Member

Found while landing ward#1142 (PR #1146).

What happened

Recent reaper-committed work (fbbc6320, c0fb2de1 and siblings, the residual-claude-work commits from 2026-07-12) landed on main without the pre-commit gate running. That left main red on two catalog hooks:

code-comments - 40 violations (comment blocks over the 2-line cap) across ten cmd/ward files.
issue-refs - terse refs in docs/FEATURES.md and docs/release.md.

Because the code-comments hook is tree-walking (it scans every tracked file, not just staged ones), a red main blocks every later hook-clean commit in any container: the next engineer's first commit fails on debt it did not create. The ward#1142 branch had to carry an unrelated burndown commit (a5c0bdee) just to be able to commit at all.

Fix directions

Have the reaper run the pre-commit suite before committing residual work, and fall back to a ward-salvage branch when the tree is red, instead of pushing a red tree to main.
Or run the catalog suite as a required CI check on main pushes, so a bypassed local gate still fails loudly at the forge.

The burndown itself is done in a5c0bdee - this issue is about the gate hole, not the debt.

Filed by the ward#1142 engineer run.

Found while landing ward#1142 (PR #1146). ## What happened Recent reaper-committed work (fbbc6320, c0fb2de1 and siblings, the residual-claude-work commits from 2026-07-12) landed on main without the pre-commit gate running. That left main red on two catalog hooks: * code-comments - 40 violations (comment blocks over the 2-line cap) across ten cmd/ward files. * issue-refs - terse refs in docs/FEATURES.md and docs/release.md. Because the code-comments hook is tree-walking (it scans every tracked file, not just staged ones), a red main blocks every later hook-clean commit in any container: the next engineer's first commit fails on debt it did not create. The ward#1142 branch had to carry an unrelated burndown commit (a5c0bdee) just to be able to commit at all. ## Fix directions * Have the reaper run the pre-commit suite before committing residual work, and fall back to a ward-salvage branch when the tree is red, instead of pushing a red tree to main. * Or run the catalog suite as a required CI check on main pushes, so a bypassed local gate still fails loudly at the forge. The burndown itself is done in a5c0bdee - this issue is about the gate hole, not the debt. Filed by the ward#1142 engineer run.

coilyco-ops commented

2026-07-13 03:38:30 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-ward-1147 on host KAI-DESKTOP-TOWER.

Reserved by ward agent --harness codex (reserved 2026-07-13T03:38:26Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (3h TTL). --override-reservation overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/ward#1147 · branch issue-1147 · harness codex · workflow pull-request-and-merge
Run: engineer-codex-ward-1147 · ward v0.633.0 · dispatched 2026-07-13T03:38:26Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.633.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-ward-1147` on host `KAI-DESKTOP-TOWER`. Reserved by `ward agent --harness codex` (reserved 2026-07-13T03:38:26Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (3h TTL). `--override-reservation` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/ward#1147` · branch `issue-1147` · harness `codex` · workflow `pull-request-and-merge` - **Run:** `engineer-codex-ward-1147` · ward `v0.633.0` · dispatched `2026-07-13T03:38:26Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.633.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue from a pull request that will close it,

2026-07-13 04:01:21 +00:00

fix: gate reaper main pushes on pre-commit #1164

coilyco-ops commented

2026-07-13 04:03:43 +00:00

Author

Member

WARD-OUTCOME: submitted

details

workflow: pull-request-and-merge; review summary: skipped (temporary ward default pending brokered QA)
felt: steady and a little detour-heavy. the reaper gate was the real fix, but the repo also needed the existing comment burndown to clear pre-commit.
confidence: high
surprises: Forgejo PR merge stayed mergeable=false even after the test workflow passed.
follow-ups: director merge PR #1164, then land main.

WARD-OUTCOME: submitted <details><summary>details</summary> workflow: pull-request-and-merge; review summary: skipped (temporary ward default pending brokered QA) felt: steady and a little detour-heavy. the reaper gate was the real fix, but the repo also needed the existing comment burndown to clear pre-commit. confidence: high surprises: Forgejo PR merge stayed mergeable=false even after the test workflow passed. follow-ups: director merge PR #1164, then land main. </details>

coilyco-ops closed this issue

2026-07-13 04:12:28 +00:00