fix(launch): name the config source in fail-closed defaults errors + skip refresh for pinned shas #1127

Merged

coilysiren merged 1 commit from fix/smartdefaults-error-source into main

2026-07-12 06:23:04 +00:00

coilysiren commented

2026-07-12 06:18:57 +00:00

Owner

Two launch-stability fixes from tonight's stale-pin incident (aos#452 / aos#472 chain):

Config-source attribution - a fail-closed smart-defaults error now reads ... (fail-closed) [config source: <ref> (bundle <sha>)]. Tonight's agent-reservation-ttl 1h must exceed role "engineer" execution-time-limit 90m named the value but not the bundle serving it - the 1h was a stale commit-pinned WARD_CONFIG_REF from a shell stamped pre-fix, and nothing pointed there.
Immutable-pin refresh skip - a full-sha WARD_CONFIG_REF whose commit already exists in the mirror skips the TTL refresh: the pin cannot resolve differently, and the refetch's failures (expired SSO git credential, offline) were pure launch noise on every invocation past the TTL.

Both covered by new tests (TestSmartDefaultsFailureNamesTheConfigSource, TestSyncGitRefImmutableShaSkipsRefresh).

Refs ward#1086, aos#452.

Two launch-stability fixes from tonight's stale-pin incident (aos#452 / aos#472 chain): * **Config-source attribution** - a fail-closed smart-defaults error now reads `... (fail-closed) [config source: <ref> (bundle <sha>)]`. Tonight's `agent-reservation-ttl 1h must exceed role "engineer" execution-time-limit 90m` named the value but not the bundle serving it - the 1h was a stale commit-pinned WARD_CONFIG_REF from a shell stamped pre-fix, and nothing pointed there. * **Immutable-pin refresh skip** - a full-sha WARD_CONFIG_REF whose commit already exists in the mirror skips the TTL refresh: the pin cannot resolve differently, and the refetch's failures (expired SSO git credential, offline) were pure launch noise on every invocation past the TTL. Both covered by new tests (`TestSmartDefaultsFailureNamesTheConfigSource`, `TestSyncGitRefImmutableShaSkipsRefresh`). Refs ward#1086, aos#452.

coilysiren added 1 commit

2026-07-12 06:18:57 +00:00

fix(launch): name the config source in fail-closed defaults errors + skip refresh for pinned shas

test / test (pull_request) Successful in 32s

Details

c0fb2de18e

Two launch-stability fixes from tonight's stale-pin incident (aos#452 /
aos#472 chain):

* A fail-closed smart-defaults error now carries the serving config
  source: "... (fail-closed) [config source: <ref> (bundle <sha>)]".
  The reservation-TTL error named the bad value but not the bundle that
  served it, which cost the whole diagnosis chain - the 1h was a stale
  commit-pinned WARD_CONFIG_REF from a shell stamped before the fix
  landed, and nothing in the message pointed there.
* A full-sha WARD_CONFIG_REF whose commit is already in the mirror now
  skips the TTL refresh entirely: the pin is immutable, so the refetch
  bought nothing and its failures (expired SSO git credential, offline)
  added launch noise on every ward invocation past the TTL.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016Cym37PsLtA61parAQyeAw

coilysiren merged commit 333b7681ef into main

2026-07-12 06:23:04 +00:00

coilysiren referenced this pull request from a commit

2026-07-12 06:23:05 +00:00

Merge pull request 'fix(launch): name the config source in fail-closed defaults errors + skip refresh for pinned shas' (#1127) from fix/smartdefaults-error-source into main