Correct issue-reference guard rollout pin and trifecta handling #5

New issue

Closed

opened 2026-07-09 19:46:03 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-09 19:46:03 +00:00

Member

Follow-up to commit 136a21ec3bdc45e135e51b5d4b58986fb2e0eb47 from coilyco-flight-deck/node-stats-mcp#4.

Kai called out two rollout quirks that need correction:

Do not make the catalog trifecta an exception to issue-reference-guard.
Pin the AOS hook by release tag, not commit hash.

Current problematic diff:

[tool.agentic-os.issue-reference-guard]
enabled = true
# Keep the catalog-trifecta convention footer in the three top-level entrypoints.
allow_globs = [
  "README.md",
  "AGENTS.md",
  "docs/FEATURES.md",
]

- repo: https://forgejo.coilysiren.me/coilyco-flight-deck/agentic-os
  rev: e69540e1c37c26fcf1db303bc4cabbf1c71c69b3
  hooks:
    - id: issue-reference-guard
      stages: [manual]

Notes:

e69540e1c37c26fcf1db303bc4cabbf1c71c69b3 is tagged as v0.230.0 on the Forgejo AOS remote, so use that tag unless a newer release tag is intentionally chosen.
catalog-trifecta does not require the old agentic-os#59 footer. It requires a durable citation to features-release-tooling.md, plus links among README, AGENTS, docs/FEATURES, and .ward/ward.yaml.
Therefore the trifecta files should be brought into compliance without an allow_globs exemption.

Acceptance:

Remove the allow_globs exception for README.md, AGENTS.md, and docs/FEATURES.md.
Replace the issue-ref footer in the trifecta files with a durable docs citation that satisfies catalog-trifecta and issue-reference-guard together.
Change the issue-reference-guard pre-commit rev from the raw SHA to a release tag, preferably v0.230.0 because it is the tag for the pinned commit.
Run ward precommit or the repo's equivalent validation, including catalog-trifecta and issue-reference-guard.
Commit and push to Forgejo main with closes #N.

Follow-up to commit `136a21ec3bdc45e135e51b5d4b58986fb2e0eb47` from `coilyco-flight-deck/node-stats-mcp#4`. Kai called out two rollout quirks that need correction: 1. Do not make the catalog trifecta an exception to `issue-reference-guard`. 2. Pin the AOS hook by release tag, not commit hash. Current problematic diff: ```toml [tool.agentic-os.issue-reference-guard] enabled = true # Keep the catalog-trifecta convention footer in the three top-level entrypoints. allow_globs = [ "README.md", "AGENTS.md", "docs/FEATURES.md", ] ``` ```yaml - repo: https://forgejo.coilysiren.me/coilyco-flight-deck/agentic-os rev: e69540e1c37c26fcf1db303bc4cabbf1c71c69b3 hooks: - id: issue-reference-guard stages: [manual] ``` Notes: * `e69540e1c37c26fcf1db303bc4cabbf1c71c69b3` is tagged as `v0.230.0` on the Forgejo AOS remote, so use that tag unless a newer release tag is intentionally chosen. * `catalog-trifecta` does **not** require the old `agentic-os#59` footer. It requires a durable citation to `features-release-tooling.md`, plus links among README, AGENTS, docs/FEATURES, and `.ward/ward.yaml`. * Therefore the trifecta files should be brought into compliance without an `allow_globs` exemption. Acceptance: * Remove the `allow_globs` exception for `README.md`, `AGENTS.md`, and `docs/FEATURES.md`. * Replace the issue-ref footer in the trifecta files with a durable docs citation that satisfies `catalog-trifecta` and `issue-reference-guard` together. * Change the `issue-reference-guard` pre-commit `rev` from the raw SHA to a release tag, preferably `v0.230.0` because it is the tag for the pinned commit. * Run `ward precommit` or the repo's equivalent validation, including `catalog-trifecta` and `issue-reference-guard`. * Commit and push to Forgejo `main` with `closes #N`.

coilyco-ops commented

2026-07-09 19:46:17 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-node-stats-mcp-5 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-09T19:46:14Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/node-stats-mcp#5 · branch issue-5 · harness codex · workflow direct-to-main
Run: engineer-codex-node-stats-mcp-5 · ward v0.493.0 · dispatched 2026-07-09T19:46:14Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-node-stats-mcp-5` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-09T19:46:14Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/node-stats-mcp#5` · branch `issue-5` · harness `codex` · workflow `direct-to-main` - **Run:** `engineer-codex-node-stats-mcp-5` · ward `v0.493.0` · dispatched `2026-07-09T19:46:14Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue from a commit

2026-07-09 19:53:16 +00:00

fix: align trifecta and rollout pins

coilyco-ops closed this issue

2026-07-09 19:53:16 +00:00

coilyco-ops commented

2026-07-09 19:53:44 +00:00

Author

Member

WARD-OUTCOME: done ✅

details

workflow: direct-to-main; review summary: review gate skipped by ~/.ward/config.yaml default
retrospective: aligned the hook pin, then the trifecta citation and local doc fell into place
confidence: high
surprises: validate-skills was renamed to check-skills in the newer agentic-os hook set
follow-ups: none

WARD-OUTCOME: done ✅ <details><summary>details</summary> workflow: direct-to-main; review summary: review gate skipped by ~/.ward/config.yaml default retrospective: aligned the hook pin, then the trifecta citation and local doc fell into place confidence: high surprises: `validate-skills` was renamed to `check-skills` in the newer agentic-os hook set follow-ups: none </details>