chore(code-comments): clean comment-discipline violations #17

New issue

Closed

opened 2026-06-08 21:50:58 +00:00 by coilysiren · 0 comments

coilysiren commented

2026-06-08 21:50:58 +00:00

Owner

What

The code-comments pre-commit check (ships from agentic-os) targets two patterns Kai wants gone across her repos:

oversized contiguous comment blocks explaining code that is simple on its own
comments documenting the previous state of the world where the prior state does not matter

This repo carries 34 latent violations under the current check (v0.16.0): 0 in code, 34 in YAML.

Why these are latent

This repo pins agentic-os v0.11.1, which predates YAML enforcement (landed in v0.14.0 on 2026-06-04). code-comments runs on code today but has never scanned YAML here, so the YAML violations are latent.

Scope

Bump the managed agentic-os rev to v0.16.0.
Clean the YAML violations the upgraded check surfaces.

Top offenders:

chart/values.yaml - 20
.github/workflows/docker.yml - 3
chart/templates/networkpolicy.yaml - 3
.coily/coily.yaml - 2
.pre-commit-config.yaml - 2
examples/values-homelab.yaml - 2

Done when

the repo pins agentic-os v0.16.0 with - id: code-comments active in the managed block
pre-commit run code-comments --all-files passes with no excludes grandfathering, beyond genuinely generated or vendored paths

Cross-repo context: the catalogue was built 2026-06-08. Sibling meta-work is tracked in agentic-os (check changes) and infrastructure (ansible version-sync role).

## What The `code-comments` pre-commit check (ships from agentic-os) targets two patterns Kai wants gone across her repos: * oversized contiguous comment blocks explaining code that is simple on its own * comments documenting the previous state of the world where the prior state does not matter This repo carries **34** latent violations under the current check (v0.16.0): 0 in code, 34 in YAML. ## Why these are latent This repo pins agentic-os v0.11.1, which predates YAML enforcement (landed in v0.14.0 on 2026-06-04). `code-comments` runs on code today but has never scanned YAML here, so the YAML violations are latent. ## Scope * Bump the managed agentic-os rev to v0.16.0. * Clean the YAML violations the upgraded check surfaces. Top offenders: * `chart/values.yaml` - 20 * `.github/workflows/docker.yml` - 3 * `chart/templates/networkpolicy.yaml` - 3 * `.coily/coily.yaml` - 2 * `.pre-commit-config.yaml` - 2 * `examples/values-homelab.yaml` - 2 ## Done when * the repo pins agentic-os v0.16.0 with `- id: code-comments` active in the managed block * `pre-commit run code-comments --all-files` passes with no `excludes` grandfathering, beyond genuinely generated or vendored paths Cross-repo context: the catalogue was built 2026-06-08. Sibling meta-work is tracked in agentic-os (check changes) and infrastructure (ansible version-sync role).

coilysiren referenced this issue from a commit

2026-06-08 23:51:52 +00:00

chore(code-comments): clean YAML comment violations, bump agentic-os v0.16.0

coilysiren closed this issue

2026-06-08 23:51:52 +00:00