Repo fails pre-commit on clean main after v0.2.6 hook bump #12

Open
opened 2026-05-28 00:20:28 +00:00 by coilysiren · 0 comments
Owner

Symptom

Pre-commit on main fails (no working-tree changes needed to reproduce — coily exec precommit on clean tip). Surfaced while landing #11.

Failures

  • catalog-doc-size / documentation-layout: AGENTS.md (100 lines / 4781 chars), README.md (84 lines), docs/FEATURES.md (4230 chars), docs/modio.md (111 lines), and mod/README.md (not at a permitted path).
  • catalog-trifecta: AGENTS.md missing standard H2s (## Scope, ## Project shape, ## Repo boundaries, ## Commands, ## Validation, ## Safety, ## Cross-repo contracts, ## Release, ## Agent rules).
  • code-comments: 54 contiguous-comment violations across .claude/lockdown-deny.sh, mod/shell/*.cs, mod/src/*.cs, mod/**/obj/**/AssemblyInfo.cs (generated), src/eco_spec_tracker/{livereload,main,mock_data}.py, tests/test_smoke.py.

Cause

Introduced by commit 06550d5 ("pull agentic-os pre-commit hook block to v0.2.6"). The repo had not yet been groomed to fit the v0.2.6 rules.

Proposal

  • Split AGENTS.md and docs/FEATURES.md (or move detail into smaller docs/*.md files) to hit the 80-line / 4000-char caps.
  • Trim README.md and docs/modio.md to 80 lines.
  • Move mod/README.md to docs/mod-overview.md (or root) and replace with a pointer.
  • Add the trifecta H2 skeleton to AGENTS.md.
  • Collapse multi-line code comments to single-line pointers per code-comments rule. Exclude mod/**/obj/** from the hook (auto-generated MSBuild output).

Tracks follow-up to #11 (workflow change landed with SKIP=catalog-doc-size,documentation-layout,code-comments,catalog-trifecta).

**Symptom** Pre-commit on `main` fails (no working-tree changes needed to reproduce — `coily exec precommit` on clean tip). Surfaced while landing #11. **Failures** - `catalog-doc-size` / `documentation-layout`: `AGENTS.md` (100 lines / 4781 chars), `README.md` (84 lines), `docs/FEATURES.md` (4230 chars), `docs/modio.md` (111 lines), and `mod/README.md` (not at a permitted path). - `catalog-trifecta`: `AGENTS.md` missing standard H2s (`## Scope`, `## Project shape`, `## Repo boundaries`, `## Commands`, `## Validation`, `## Safety`, `## Cross-repo contracts`, `## Release`, `## Agent rules`). - `code-comments`: 54 contiguous-comment violations across `.claude/lockdown-deny.sh`, `mod/shell/*.cs`, `mod/src/*.cs`, `mod/**/obj/**/AssemblyInfo.cs` (generated), `src/eco_spec_tracker/{livereload,main,mock_data}.py`, `tests/test_smoke.py`. **Cause** Introduced by commit `06550d5` ("pull agentic-os pre-commit hook block to v0.2.6"). The repo had not yet been groomed to fit the v0.2.6 rules. **Proposal** - Split `AGENTS.md` and `docs/FEATURES.md` (or move detail into smaller `docs/*.md` files) to hit the 80-line / 4000-char caps. - Trim `README.md` and `docs/modio.md` to 80 lines. - Move `mod/README.md` to `docs/mod-overview.md` (or root) and replace with a pointer. - Add the trifecta H2 skeleton to `AGENTS.md`. - Collapse multi-line code comments to single-line pointers per `code-comments` rule. Exclude `mod/**/obj/**` from the hook (auto-generated MSBuild output). Tracks follow-up to #11 (workflow change landed with `SKIP=catalog-doc-size,documentation-layout,code-comments,catalog-trifecta`).
Sign in to join this conversation.
No labels
P0
P1
P2
P3
P4
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/eco-jobs-tracker#12
No description provided.