Clean up issue-reference guard hits #213

New issue

Closed

opened 2026-07-09 21:13:19 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-09 21:13:19 +00:00

Member

Problem

The fleet issue-reference audit in coilysiren/inbox#187 found cli-guard has 172 raw issue-reference-guard hits under scratch opt-in. This is one of the highest-hit repos and should be cleaned before enforcement rollout.

Baseline scan, 2026-07-09:

Repo: coilyco-flight-deck/cli-guard
Hits: 172 raw hook violations
Existing hook config: none. Count came from scratch opt-in.
Sample hits:
- .forgejo/workflows/ci.yml:4 bare issue ref
- AGENTS.md:44 issue URL
- AGENTS.md:55 scoped issue ref + issue URL
- README.md:49 scoped issue ref

Counts are raw hook violations, not unique lines. A single line can count more than once when it matches multiple rules.

Scope

Do a first cleanup pass in cli-guard that removes durable-prose and source comments depending on direct issue refs. Replace them with durable docs, local section anchors, or stable design language. Keep legitimate commit messages out of scope.

Do not add a blanket catalog-trifecta or generated-doc exception. If generated files are a real source of hits, capture the exact generated path and why it should be excluded.

Acceptance

Run AOS issue-reference-guard with scratch opt-in against tracked files and report the before/after hit count.
Drive the count materially down, ideally to 0 if the remaining hits are ordinary docs/code comments.
If any hits remain, document each remaining category and whether it needs an allowlist, generator change, or follow-up.
Do not enable enforcement unless the repo is actually at 0 or every remaining exemption is explicit and reviewed.
Land on Forgejo main and comment the final count back here.

Parent

Fleet tracker: coilysiren/inbox#187.

## Problem The fleet issue-reference audit in `coilysiren/inbox#187` found `cli-guard` has **172 raw `issue-reference-guard` hits** under scratch opt-in. This is one of the highest-hit repos and should be cleaned before enforcement rollout. Baseline scan, 2026-07-09: * Repo: `coilyco-flight-deck/cli-guard` * Hits: 172 raw hook violations * Existing hook config: none. Count came from scratch opt-in. * Sample hits: * `.forgejo/workflows/ci.yml:4` bare issue ref * `AGENTS.md:44` issue URL * `AGENTS.md:55` scoped issue ref + issue URL * `README.md:49` scoped issue ref Counts are raw hook violations, not unique lines. A single line can count more than once when it matches multiple rules. ## Scope Do a first cleanup pass in `cli-guard` that removes durable-prose and source comments depending on direct issue refs. Replace them with durable docs, local section anchors, or stable design language. Keep legitimate commit messages out of scope. Do not add a blanket catalog-trifecta or generated-doc exception. If generated files are a real source of hits, capture the exact generated path and why it should be excluded. ## Acceptance * Run AOS `issue-reference-guard` with scratch opt-in against tracked files and report the before/after hit count. * Drive the count materially down, ideally to 0 if the remaining hits are ordinary docs/code comments. * If any hits remain, document each remaining category and whether it needs an allowlist, generator change, or follow-up. * Do not enable enforcement unless the repo is actually at 0 or every remaining exemption is explicit and reviewed. * Land on Forgejo `main` and comment the final count back here. ## Parent Fleet tracker: `coilysiren/inbox#187`.

coilyco-ops commented

2026-07-09 21:13:38 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-cli-guard-213 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-09T21:13:35Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/cli-guard#213 · branch issue-213 · harness codex · workflow direct-to-main
Run: engineer-codex-cli-guard-213 · ward v0.493.0 · dispatched 2026-07-09T21:13:35Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-cli-guard-213` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-09T21:13:35Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/cli-guard#213` · branch `issue-213` · harness `codex` · workflow `direct-to-main` - **Run:** `engineer-codex-cli-guard-213` · ward `v0.493.0` · dispatched `2026-07-09T21:13:35Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.493.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue from coilyco-flight-deck/agentic-os

2026-07-09 21:33:12 +00:00

Stage issue-reference guard N+1 rollout after parser narrowing #381

coilyco-ops referenced this issue from a commit

2026-07-09 21:45:52 +00:00

clean up issue-reference guard hits

coilyco-ops closed this issue

2026-07-09 21:45:52 +00:00

coilyco-ops commented

2026-07-09 21:46:30 +00:00

Author

Member

WARD-OUTCOME: done ✅

details

workflow: direct-to-main; review summary: review gate skipped by ~/.ward/config.yaml default
final count: 0
retrospective: broad but mechanical cleanup, plus one generated contract seed and prompt wording follow-up
confidence: high
surprises: scratch cache pressure blocked the full Go hook chain
follow-ups: none

WARD-OUTCOME: done ✅ <details><summary>details</summary> workflow: direct-to-main; review summary: review gate skipped by ~/.ward/config.yaml default final count: 0 retrospective: broad but mechanical cleanup, plus one generated contract seed and prompt wording follow-up confidence: high surprises: scratch cache pressure blocked the full Go hook chain follow-ups: none </details>