wire validate-skills hook into agentic-os pre-commit-config #63

Open
opened 2026-05-27 22:24:21 +00:00 by coilysiren · 0 comments
Owner

Problem

coilysiren/agentic-os's own .pre-commit-config.yaml does NOT include the validate-skills hook, even though the skills it hosts (every coding-*, plus other categories via symlink targets) are subject to the same description-byte cap and structural validators that agentic-os-kai enforces.

Why this matters

The agentic-os repo is the actual home for all coding-* SKILL.md files (agentic-os-kai/.agents/skills/coding-* are symlinks). When an agent edits one of those files via the agentic-os-kai symlink, the agentic-os-kai pre-commit suite catches violations. But when an agent edits the file directly in agentic-os (or when a different consumer edits it without going through agentic-os-kai), nothing enforces the cap. The validator at /Users/kai/projects/coilysiren/agentic-os/agentic_os/validate_skills.py exists and works — it's just not wired locally.

Encountered during

Session 683a (2026-05-27) coding-* skill description sweep. Subagents had to invoke the validator with pre-commit try-repo . validate-skills --all-files because pre-commit run validate-skills failed (hook not in local config). The try-repo workaround worked, but it's a discoverability landmine for every future contributor.

Suggested fix

Add the validate-skills hook to coilysiren/agentic-os/.pre-commit-config.yaml, alongside the existing catalog-block-present and warp-go-vet hooks. The hook ID is already exposed in agentic-os/.pre-commit-hooks.yaml, so this is just one block to add to the config.

Related context

agentic-os-kai issue (already filed) tracks the broader catalog-suite rollout. This specific gap is the one missing piece for agentic-os itself, which is the canonical home for coding-* skills.

Filed by Claude (session claude-macos-kais-macbook-pro-683a) at Kai's explicit request after the coding-* sweep surfaced the gap.

**Problem** `coilysiren/agentic-os`'s own `.pre-commit-config.yaml` does NOT include the `validate-skills` hook, even though the skills it hosts (every `coding-*`, plus other categories via symlink targets) are subject to the same description-byte cap and structural validators that agentic-os-kai enforces. **Why this matters** The `agentic-os` repo is the actual home for all `coding-*` SKILL.md files (agentic-os-kai/.agents/skills/coding-* are symlinks). When an agent edits one of those files via the agentic-os-kai symlink, the agentic-os-kai pre-commit suite catches violations. But when an agent edits the file directly in agentic-os (or when a different consumer edits it without going through agentic-os-kai), nothing enforces the cap. The validator at `/Users/kai/projects/coilysiren/agentic-os/agentic_os/validate_skills.py` exists and works — it's just not wired locally. **Encountered during** Session `683a` (2026-05-27) coding-* skill description sweep. Subagents had to invoke the validator with `pre-commit try-repo . validate-skills --all-files` because `pre-commit run validate-skills` failed (hook not in local config). The try-repo workaround worked, but it's a discoverability landmine for every future contributor. **Suggested fix** Add the `validate-skills` hook to `coilysiren/agentic-os/.pre-commit-config.yaml`, alongside the existing `catalog-block-present` and `warp-go-vet` hooks. The hook ID is already exposed in `agentic-os/.pre-commit-hooks.yaml`, so this is just one block to add to the config. **Related context** agentic-os-kai issue (already filed) tracks the broader catalog-suite rollout. This specific gap is the one missing piece for agentic-os itself, which is the canonical home for coding-* skills. Filed by Claude (session `claude-macos-kais-macbook-pro-683a`) at Kai's explicit request after the coding-* sweep surfaced the gap.
coilysiren added
P3
and removed
P2
labels 2026-05-31 07:00:06 +00:00
Sign in to join this conversation.
No labels
P0
P1
P2
P3
P4
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/agentic-os#63
No description provided.