Add a conceptual fourth branch beside the README / AGENTS / docs/FEATURE… #401

New issue

Closed

opened 2026-07-10 03:38:33 +00:00 by coilyco-ops · 2 comments

coilyco-ops commented

2026-07-10 03:38:33 +00:00

Member

Add a conceptual fourth branch beside the README / AGENTS / docs/FEATURES entrypoint set: a root CODE-REVIEW.md that encodes code review components specific to ward.

Context already checked:

README.md, AGENTS.md, and docs/FEATURES.md define the current trifecta and See also cross-link shape.
.agents/skills/tooling-code-review/SKILL.md already carries the ward review stance, non-iterative rule, input order, output contract, and WARD-OUTCOME summary expectation.
agentic_os/pre_commit/check_documentation_layout.py currently rejects most root Markdown and does not allow CODE-REVIEW.md.
agentic_os/pre_commit/check_catalog_trifecta.py hard-codes the three Markdown entrypoints. Treat CODE-REVIEW.md as a conceptual branch without accidentally weakening the existing trifecta guard.

Implementation sketch:

Add root CODE-REVIEW.md with public-safe ward-specific review doctrine: what the review pass is for, required inputs, non-iterative behavior, baseline comparison, refutation stance, output shape, and how the review summary feeds WARD-OUTCOME.
Link CODE-REVIEW.md from README.md, AGENTS.md, and docs/FEATURES.md where it naturally belongs. Keep the existing trifecta links and convention citation intact.
Link back from CODE-REVIEW.md to README.md, AGENTS.md, docs/FEATURES.md, .ward/ward.yaml, and the existing tooling-code-review skill reference as appropriate.
Update documentation-layout allow-list, tests, and docs that enumerate allowed root Markdown so CODE-REVIEW.md passes intentionally.
Decide whether catalog-trifecta remains a strict three-doc validator or grows an explicit optional CODE-REVIEW.md branch. Preserve existing behavior for repos that do not have CODE-REVIEW.md.
Update docs/FEATURES.md because this adds a user and agent visible documentation surface.

Acceptance criteria:

CODE-REVIEW.md exists at repo root and is specific to ward review, not generic review advice.
The new doc is discoverable from the current entrypoint docs.
Existing validators pass without per-repo excludes.
Tests cover the new root Markdown allowance and any catalog behavior change.
pre-commit run --all-files passes.

Filed by ward agent engineer --harness codex.

— Codex, via ward agent

Add a conceptual fourth branch beside the README / AGENTS / docs/FEATURES entrypoint set: a root CODE-REVIEW.md that encodes code review components specific to ward. Context already checked: * README.md, AGENTS.md, and docs/FEATURES.md define the current trifecta and See also cross-link shape. * .agents/skills/tooling-code-review/SKILL.md already carries the ward review stance, non-iterative rule, input order, output contract, and WARD-OUTCOME summary expectation. * agentic_os/pre_commit/check_documentation_layout.py currently rejects most root Markdown and does not allow CODE-REVIEW.md. * agentic_os/pre_commit/check_catalog_trifecta.py hard-codes the three Markdown entrypoints. Treat CODE-REVIEW.md as a conceptual branch without accidentally weakening the existing trifecta guard. Implementation sketch: * Add root CODE-REVIEW.md with public-safe ward-specific review doctrine: what the review pass is for, required inputs, non-iterative behavior, baseline comparison, refutation stance, output shape, and how the review summary feeds WARD-OUTCOME. * Link CODE-REVIEW.md from README.md, AGENTS.md, and docs/FEATURES.md where it naturally belongs. Keep the existing trifecta links and convention citation intact. * Link back from CODE-REVIEW.md to README.md, AGENTS.md, docs/FEATURES.md, .ward/ward.yaml, and the existing tooling-code-review skill reference as appropriate. * Update documentation-layout allow-list, tests, and docs that enumerate allowed root Markdown so CODE-REVIEW.md passes intentionally. * Decide whether catalog-trifecta remains a strict three-doc validator or grows an explicit optional CODE-REVIEW.md branch. Preserve existing behavior for repos that do not have CODE-REVIEW.md. * Update docs/FEATURES.md because this adds a user and agent visible documentation surface. Acceptance criteria: * CODE-REVIEW.md exists at repo root and is specific to ward review, not generic review advice. * The new doc is discoverable from the current entrypoint docs. * Existing validators pass without per-repo excludes. * Tests cover the new root Markdown allowance and any catalog behavior change. * pre-commit run --all-files passes. --- Filed by `ward agent engineer --harness codex`.  — Codex, via `ward agent`

coilyco-ops commented

2026-07-10 03:38:54 +00:00

Author

Member

WARD-RESERVATION: held 🔒

reservation details

Holder: container engineer-codex-agentic-os-401 on host kais-macbook-pro-2.local.

Reserved by ward agent --harness codex (reserved 2026-07-10T03:38:53Z). Concurrent ward agent runs are blocked until it finishes or the reservation goes stale (1h TTL). --force overrides.

Do not comment on or edit this issue to steer the run while it is reserved. The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a new issue, dispatched fresh. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494).

run seed context — what this run is carrying (ward#609)

Resolved: coilyco-flight-deck/agentic-os#401 · branch issue-401 · harness codex · workflow direct-main
Run: engineer-codex-agentic-os-401 · ward v0.554.0 · dispatched 2026-07-10T03:38:53Z
Comment thread: 0 included in the pre-flight read, 0 stripped (ward's own automated comments).

Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.554.0).

— Codex, via ward agent

WARD-RESERVATION: held 🔒 <details><summary>reservation details</summary> Holder: container `engineer-codex-agentic-os-401` on host `kais-macbook-pro-2.local`. Reserved by `ward agent --harness codex` (reserved 2026-07-10T03:38:53Z). Concurrent `ward agent` runs are blocked until it finishes or the reservation goes stale (1h TTL). `--force` overrides. **Do not comment on or edit this issue to steer the run while it is reserved.** The engineer seeded the body once at launch and never re-reads it, so a comment or edit reaches only human readers, never the running engineer. A correction goes to a **new issue, dispatched fresh**. That is the only channel that reaches a run in flight. Where the forge supports it, ward locks this conversation to make that a road-block rather than a convention (ward#494). <details><summary>run seed context — what this run is carrying (ward#609)</summary> - **Resolved:** `coilyco-flight-deck/agentic-os#401` · branch `issue-401` · harness `codex` · workflow `direct-main` - **Run:** `engineer-codex-agentic-os-401` · ward `v0.554.0` · dispatched `2026-07-10T03:38:53Z` - **Comment thread:** 0 included in the pre-flight read, 0 stripped (ward's own automated comments). Static container doctrine and seed boilerplate are identical every run and omitted here (they ride ward v0.554.0). </details> </details>  — Codex, via `ward agent`

coilyco-ops referenced this issue

2026-07-10 03:47:53 +00:00

Add a code-review contract validator beside catalog-trifecta #402

coilyco-ops commented

2026-07-10 03:48:19 +00:00

Author

Member

Superseded by coilyco-flight-deck/agentic-os#402. The corrected request is for a new aos validator and review-contract documentation, not only adding the document itself.

coilyco-ops closed this issue

2026-07-10 03:48:20 +00:00