code-comments: soften to 2 contiguous lines, exempt eco-* repos #24

New issue

Closed

opened 2026-05-26 02:48:50 +00:00 by coilysiren · 0 comments

coilysiren commented

2026-05-26 02:48:50 +00:00

Owner

Problem

The code-comments validator at MAX_CONTIGUOUS=1 rejects every two-line Python explanation and every multi-line Go godoc. Survey across coilysiren/* finds 14,018 violations at TOL=1, 9,932 at TOL=2. The dominant pattern is first-party idiomatic style, not vendored content.

Eco-modding repos (eco-*) sit on Unity / C# trees with mod-author comment conventions that conflict with the rule shape entirely.

Fix

check_code_comments.py: bump MAX_CONTIGUOUS_COMMENT_LINES to 2. Two-line blocks pass; 3+ contiguous still flagged. Single-line + 90-char cap unchanged.
apply-agentic-os-hooks.py: per-repo skip list. Repos matching eco-* prefix get the managed block without code-comments. Other validators (documentation-layout, etc) still apply.

Out of scope

The vendored-file escape hatch from #22 (per-hook exclude preservation, git ls-files filter). Separately tracked.

Follow-up

After v0.2.8 ships and rolls out, file a cleanup issue per non-eco repo with non-zero violations. Fan out via coily dispatch interactive.

**Problem** The code-comments validator at MAX_CONTIGUOUS=1 rejects every two-line Python explanation and every multi-line Go godoc. Survey across coilysiren/* finds 14,018 violations at TOL=1, 9,932 at TOL=2. The dominant pattern is first-party idiomatic style, not vendored content. Eco-modding repos (eco-*) sit on Unity / C# trees with mod-author comment conventions that conflict with the rule shape entirely. **Fix** - `check_code_comments.py`: bump `MAX_CONTIGUOUS_COMMENT_LINES` to 2. Two-line blocks pass; 3+ contiguous still flagged. Single-line + 90-char cap unchanged. - `apply-agentic-os-hooks.py`: per-repo skip list. Repos matching `eco-*` prefix get the managed block without `code-comments`. Other validators (documentation-layout, etc) still apply. **Out of scope** The vendored-file escape hatch from #22 (per-hook exclude preservation, git ls-files filter). Separately tracked. **Follow-up** After v0.2.8 ships and rolls out, file a cleanup issue per non-eco repo with non-zero violations. Fan out via `coily dispatch interactive`.

coilysiren referenced this issue from a commit

2026-05-26 02:49:36 +00:00

code-comments: soften to 2 contiguous lines, exempt eco-* repos

coilysiren closed this issue

2026-05-26 02:49:36 +00:00

coilysiren referenced this issue

2026-05-26 02:50:45 +00:00

rollout: bump DEFAULT_REV to v0.2.8 #25

coilysiren referenced this issue

2026-05-26 02:55:43 +00:00

chore: clean up code-comments violations (agentic-os v0.2.8) #26

coilysiren referenced this issue from coilyco-bridge/sirens-discord-ops