refactor(hooks)!: retire check-issue-refs.sh #1288

Merged
coilyco-ops merged 1 commit from aos/claude/ff54-retire-issue-refs into main 2026-08-26 18:17:37 +00:00
Owner

Authoring half of retiring the issue-ref hook. Rollout is coilyco-flight-deck/infrastructure#949, and the up-to-date.py assertion is already dropped in agentic-os-kai (393da23).

Why

The hook guarded how an agent spelled a reference in chat, which is the one artifact that does not survive the session. Its Stop leg read the transcript slice after the last user record, and tool results are recorded as user, so a tool-heavy turn inspected an empty string rather than the reply.

What goes

  • scripts/check-issue-refs.sh
  • the "Issue-ref Stop hook" section of docs/native-claude-credentials.md, and the neighbouring "both guardrails" wording that counted it

No test referenced the script. aos/claude/issue-refs-write-path, the branch that would have rewired it as a PreToolUse hook, is dropped rather than landed.

🤖 Generated with Claude Code

Authoring half of retiring the issue-ref hook. Rollout is https://forgejo.coilysiren.me/coilyco-flight-deck/infrastructure/pulls/949, and the `up-to-date.py` assertion is already dropped in agentic-os-kai (`393da23`). ## Why The hook guarded how an agent spelled a reference in chat, which is the one artifact that does not survive the session. Its Stop leg read the transcript slice after the last `user` record, and tool results are recorded as `user`, so a tool-heavy turn inspected an empty string rather than the reply. ## What goes * `scripts/check-issue-refs.sh` * the "Issue-ref Stop hook" section of `docs/native-claude-credentials.md`, and the neighbouring "both guardrails" wording that counted it No test referenced the script. `aos/claude/issue-refs-write-path`, the branch that would have rewired it as a PreToolUse hook, is dropped rather than landed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
refactor(hooks)!: retire check-issue-refs.sh
All checks were successful
ci / ward-doctor (pull_request) Successful in 7s
ci / aos-eval-tests (pull_request) Successful in 9s
ci / aos-cli-tests (pull_request) Successful in 29s
ci / gate (pull_request) Successful in 46s
45a1ef93ad
The hook policed how an agent spelled a reference in chat rather than anything
durable, so it guarded the one artifact that does not survive the session. Its
Stop leg also read the transcript slice after the last `user` record, and tool
results are recorded as `user`, so a tool-heavy turn inspected an empty string
rather than the reply.

The claude-hooks ansible role unwires both the Stop entry and a hand-wired
PreToolUse copy, and agentic-os-kai drops the up-to-date assertion.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Kai Siren <coilysiren@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Agent-Role: platform
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
coilyco-flight-deck/agentic-os!1288
No description provided.