coilyco-flight-deck/agentic-os
1
0
Fork 0
Code Issues 33 Pull requests Projects Releases Packages Wiki Activity Actions

commit-msg hook: require an issue reference, not a close #121

New issue
Open
opened 2026-05-31 06:47:57 +00:00 by coilysiren · 0 comments
coilysiren commented 2026-05-31 06:47:57 +00:00
Owner
Copy link

commit-msg hook: require an issue reference, not a close

check_commit_closes_issue.py (the commit-msg hook, canonical here and rolled out to every coilysiren/* repo) required a closing keyword (close/fixes/resolves) in front of the Forgejo issue URL. Kai asked to relax this: every commit must reference an issue, not necessarily close it.

Change

  • Made the closing keyword optional in URL_RE — a bare same-repo Forgejo issue URL now satisfies the rule.
  • Reworded the docstring, ERROR_NO_REF, the pre-commit hook display name, and docs/skill-discipline/handbook.md from "close" to "reference".
  • Added tests test_url_without_keyword_accepted and test_inline_url_reference_accepted.
  • The URL-only safety property is unchanged: bare #N / owner/repo#N with a keyword are still rejected (GitHub auto-close risk on mirrored repos), and cross-repo Forgejo URLs are still rejected.

Follow-up (loosen to fire only on commits merging into main) tracked separately at coilysiren/inbox#4.

## commit-msg hook: require an issue *reference*, not a *close* `check_commit_closes_issue.py` (the `commit-msg` hook, canonical here and rolled out to every `coilysiren/*` repo) required a closing keyword (`close`/`fixes`/`resolves`) in front of the Forgejo issue URL. Kai asked to relax this: every commit must **reference** an issue, not necessarily close it. ### Change - Made the closing keyword **optional** in `URL_RE` — a bare same-repo Forgejo issue URL now satisfies the rule. - Reworded the docstring, `ERROR_NO_REF`, the pre-commit hook display name, and `docs/skill-discipline/handbook.md` from "close" to "reference". - Added tests `test_url_without_keyword_accepted` and `test_inline_url_reference_accepted`. - The URL-only safety property is unchanged: bare `#N` / `owner/repo#N` with a keyword are still rejected (GitHub auto-close risk on mirrored repos), and cross-repo Forgejo URLs are still rejected. Follow-up (loosen to fire only on commits merging into main) tracked separately at coilysiren/inbox#4.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
docs-o2r-command-delivery-qwen-storage
v0.11.1
v0.11.0
v0.10.0
v0.9.0
v0.8.0
v0.7.0
v0.6.0
v0.5.0
v0.4.0
v0.3.0
v0.2.12
v0.2.11
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.0
Labels
Clear labels
  
P0
now / blocking / urgent

  
P1
next / important

  
P2
backlog / will do

  
P3
someday / low

  
P4
icebox / frozen / reopen if it becomes real

No labels
P0
P1
P2
P3
P4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-flight-deck/agentic-os#121
No description provided.