feat(pre-commit): skip .vscode JSONC in the generated check-json hook #1160

Merged

coilysiren merged 1 commit from feat/check-json-vscode into main

2026-08-20 09:12:23 +00:00

coilyco-ops commented

2026-08-20 09:03:45 +00:00

Owner

VS Code documents launch.json, tasks.json, and settings.json as JSONC, so those files carry // comments by design and a strict JSON parser cannot read them. That is true of every consumer rather than a per-repo choice, so the exclude is fixed on the hook instead of declared in a consumer's pyproject.

Renaming is not an option: VS Code resolves those three by exact name.

Found via coilyco-gaming/eco-ops#91, where mods/.vscode/launch.json was the sole check-json failure.

This commit was originally pushed onto the #1159 branch a few minutes after that PR merged, so it never reached main. Same change, rebased onto current main.

Refs coilyco-gaming/eco-ops#91

VS Code documents `launch.json`, `tasks.json`, and `settings.json` as JSONC, so those files carry `//` comments by design and a strict JSON parser cannot read them. That is true of every consumer rather than a per-repo choice, so the exclude is fixed on the hook instead of declared in a consumer's pyproject. Renaming is not an option: VS Code resolves those three by exact name. Found via coilyco-gaming/eco-ops#91, where `mods/.vscode/launch.json` was the sole check-json failure. This commit was originally pushed onto the #1159 branch a few minutes after that PR merged, so it never reached `main`. Same change, rebased onto current `main`. Refs coilyco-gaming/eco-ops#91

coilyco-ops added 1 commit

2026-08-20 09:03:45 +00:00

feat(pre-commit): skip .vscode JSONC in the generated check-json hook

ci / aos-eval-tests (pull_request) Successful in 5s

Details

ci / aos-cli-tests (pull_request) Successful in 17s

Details

ci / ward-doctor (pull_request) Successful in 11s

Details

ci / gate (pull_request) Successful in 56s

Details

cc6bffeb9e

VS Code documents launch.json, tasks.json, and settings.json as JSONC, so
those files carry // comments by design and a strict JSON parser cannot read
them. That is true of every consumer, not a per-repo choice, so the exclude
is fixed on the hook rather than declared.

Renaming is not an option: VS Code resolves those three by exact name.

Refs coilyco-gaming/eco-ops#91

coilyco-ops requested review from coilysiren

2026-08-20 09:03:45 +00:00

coilysiren merged commit 82f085c40d into main

2026-08-20 09:12:23 +00:00

coilysiren referenced this pull request from a commit

2026-08-20 09:12:26 +00:00

feat(pre-commit): skip .vscode JSONC in the generated check-json hook (#1160)

coilysiren deleted branch feat/check-json-vscode

2026-08-20 09:12:26 +00:00