This repo has no pre-commit config, and adopting the suite is not a drop-in #87

New issue

Closed

opened 2026-08-11 00:40:58 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-11 00:40:58 +00:00

Member

agent-proxy ships no .pre-commit-config.yaml. Running pre-commit run --all-files here fails with InvalidConfigError: .pre-commit-config.yaml is not a file, so none of the catalog validators have ever run against this tree.

Why it was missed

agentic-os/scripts/apply-agentic-os-hooks.py drives off "every git working tree under ~/projects/<org>/*". This repository is not in the on-disk residency set, so the rollout has never seen it. Tracked separately at coilyco-flight-deck/agentic-os. ward-mcp is missing it for the same reason.

What adopting it costs

I generated the config with the owning tool (--rev aos-precommit-v0.18.0) against a scratch copy and ran the suite. 15 hooks pass, 11 fail. Nothing below is committed.

Mechanical, minutes each

context-load-points - add a CLAUDE.md containing exactly @AGENTS.md. One file.
catalog-block-present - .ward/ward.yaml needs a top-level catalog: block.
catalog-trifecta - README.md needs a ## See also section linking AGENTS.md, docs/FEATURES.md, and .ward/ward.yaml.
source-doc-refs - .ward/ward.yaml:3 points at docs/ward-yaml.md, which does not exist.
trailing-whitespace and end-of-file-fixer - auto-fixed on run.

Likely repo config rather than defects

typos - flags ser inside ser8, our own host name. Needs an allowlist, not a correction. About 50 output lines, mostly this.
actionlint - rejects runs-on: docker, which is the self-hosted Forgejo runner label. Needs an actionlint config, not a workflow change.

Real work

code-comments - 97 output lines, dominated by .ward/ward.yaml comments sitting below the top header block.
catalog-doc-size and documentation-layout - docs/architecture-v2.md is 10839 chars and 180 lines against caps of 4000 and 80. docs/FEATURES.md is 8181 chars. docs/ROADMAP.md is 5810. Splitting these is editorial work, and architecture-v2.md is load-bearing for the v2 migration.
actions-run-one-line - two python3 -c bodies inlined in .forgejo/workflows/ci.yml need extracting into tracked scripts.

Worth knowing before picking a rev

deploy is still pinned to the older v0.102.0 block, which carries neither typos nor actionlint nor actions-run-one-line. Adopting aos-precommit-v0.18.0 here would make agent-proxy the first repo on the newer set, so it would absorb new-hook friction that is not specific to this repository. Pinning to the same rev the rest of the fleet runs is a smaller first step.

Suggested order

Land the config with the doc-size and code-comment hooks temporarily excluded, fix the mechanical items and the two config gaps in that same change, then remove the exclusions as the docs get split. That keeps main green throughout instead of landing a repo that fails its own gate.

`agent-proxy` ships no `.pre-commit-config.yaml`. Running `pre-commit run --all-files` here fails with `InvalidConfigError: .pre-commit-config.yaml is not a file`, so none of the catalog validators have ever run against this tree. ## Why it was missed `agentic-os/scripts/apply-agentic-os-hooks.py` drives off "every git working tree under `~/projects/<org>/*`". This repository is not in the on-disk residency set, so the rollout has never seen it. Tracked separately at coilyco-flight-deck/agentic-os. `ward-mcp` is missing it for the same reason. ## What adopting it costs I generated the config with the owning tool (`--rev aos-precommit-v0.18.0`) against a scratch copy and ran the suite. **15 hooks pass, 11 fail.** Nothing below is committed. **Mechanical, minutes each** * `context-load-points` - add a `CLAUDE.md` containing exactly `@AGENTS.md`. One file. * `catalog-block-present` - `.ward/ward.yaml` needs a top-level `catalog:` block. * `catalog-trifecta` - `README.md` needs a `## See also` section linking `AGENTS.md`, `docs/FEATURES.md`, and `.ward/ward.yaml`. * `source-doc-refs` - `.ward/ward.yaml:3` points at `docs/ward-yaml.md`, which does not exist. * `trailing-whitespace` and `end-of-file-fixer` - auto-fixed on run. **Likely repo config rather than defects** * `typos` - flags `ser` inside `ser8`, our own host name. Needs an allowlist, not a correction. About 50 output lines, mostly this. * `actionlint` - rejects `runs-on: docker`, which is the self-hosted Forgejo runner label. Needs an actionlint config, not a workflow change. **Real work** * `code-comments` - 97 output lines, dominated by `.ward/ward.yaml` comments sitting below the top header block. * `catalog-doc-size` and `documentation-layout` - `docs/architecture-v2.md` is 10839 chars and 180 lines against caps of 4000 and 80. `docs/FEATURES.md` is 8181 chars. `docs/ROADMAP.md` is 5810. Splitting these is editorial work, and `architecture-v2.md` is load-bearing for the v2 migration. * `actions-run-one-line` - two `python3 -c` bodies inlined in `.forgejo/workflows/ci.yml` need extracting into tracked scripts. ## Worth knowing before picking a rev `deploy` is still pinned to the older `v0.102.0` block, which carries neither `typos` nor `actionlint` nor `actions-run-one-line`. Adopting `aos-precommit-v0.18.0` here would make `agent-proxy` the first repo on the newer set, so it would absorb new-hook friction that is not specific to this repository. Pinning to the same rev the rest of the fleet runs is a smaller first step. ## Suggested order Land the config with the doc-size and code-comment hooks temporarily excluded, fix the mechanical items and the two config gaps in that same change, then remove the exclusions as the docs get split. That keeps `main` green throughout instead of landing a repo that fails its own gate.

coilyco-ops referenced this issue from coilyco-flight-deck/agentic-os

2026-08-11 00:41:19 +00:00

Hook rollout coverage is checkout-driven, so non-resident repos silently never get the suite #991

coilyco-ops referenced this issue

2026-08-11 00:57:54 +00:00

Split the nine oversized docs under the layout caps #88

coilyco-ops referenced this issue

2026-08-11 00:58:04 +00:00

Bring 96 comment blocks under the two-line discipline #89

coilyco-ops referenced this issue from a commit

2026-08-11 01:00:28 +00:00

chore: adopt the catalog pre-commit suite at aos-precommit-v0.18.0