`just smoke` fails on two stale assertions, and has been red on main since before the reflow #319

New issue

Open

opened 2026-08-22 20:13:45 +00:00 by coilyco-ops · 0 comments

coilyco-ops commented

2026-08-22 20:13:45 +00:00

Member

Found while updating scripts/smoke.sh for the seven-seat reflow. This is not caused by the reflow. I reproduced it on a detached worktree at de934cc, the tip before any of my commits, on a clean checkout.

just smoke is not part of just test, which is why it went unnoticed: scripts/test.sh runs the Go suite, the palette test, and the pre-commit sweep, and never calls the smoke.

Failure one

smoke: .../home/.agent-compose/COMPOSED.md does not contain: opal engineer

scripts/smoke.sh:184 asserts opal engineer appears in the composed output. No fixture in the smoke tree writes that name, and grep -r opal across the repo finds it only in docs/person-contract.md and docs/statusline.md as documentation examples, plus two test fixtures that build their own person. The composed file carries **Agent // Angie (she)** and the other shipped seat names instead.

So the assertion appears to be a leftover from an identity-override era rather than a real regression. It should either assert a seat the smoke actually produces, or the smoke should install an identity override that produces the seat it asserts. I did not guess which, so it is untouched apart from the rename.

Failure two

With the first assertion stubbed out to keep going:

smoke: .../role-introduction.txt does not contain:
  fake codex <Introduce yourself now as the active Codex seat

This is the bare-Codex introduction launch, which shells a stub fake codex from $smoke_root/bin. It reaches the assertion, so the launch itself runs. Whether the prompt text moved or the stub is not being reached the way the assertion expects, I did not chase.

Reproduction

git worktree add --detach /tmp/acompose-main-check de934cc
cd /tmp/acompose-main-check && sh scripts/smoke.sh

What did change here

12c7198 renamed the slugs the smoke drives: the composed-skill role binding, the launched role, the projected role-* and personality-* skill paths, and the assertion strings that name them. Those edits are mechanical and do not touch either failing assertion.

Found while updating `scripts/smoke.sh` for the seven-seat reflow. **This is not caused by the reflow.** I reproduced it on a detached worktree at `de934cc`, the tip before any of my commits, on a clean checkout. `just smoke` is not part of `just test`, which is why it went unnoticed: `scripts/test.sh` runs the Go suite, the palette test, and the pre-commit sweep, and never calls the smoke. ## Failure one ``` smoke: .../home/.agent-compose/COMPOSED.md does not contain: opal engineer ``` `scripts/smoke.sh:184` asserts `opal engineer` appears in the composed output. No fixture in the smoke tree writes that name, and `grep -r opal` across the repo finds it only in `docs/person-contract.md` and `docs/statusline.md` as documentation examples, plus two test fixtures that build their own person. The composed file carries `**Agent // Angie (she)**` and the other shipped seat names instead. So the assertion appears to be a leftover from an identity-override era rather than a real regression. It should either assert a seat the smoke actually produces, or the smoke should install an identity override that produces the seat it asserts. I did not guess which, so it is untouched apart from the rename. ## Failure two With the first assertion stubbed out to keep going: ``` smoke: .../role-introduction.txt does not contain: fake codex <Introduce yourself now as the active Codex seat ``` This is the bare-Codex introduction launch, which shells a stub `fake codex` from `$smoke_root/bin`. It reaches the assertion, so the launch itself runs. Whether the prompt text moved or the stub is not being reached the way the assertion expects, I did not chase. ## Reproduction ```sh git worktree add --detach /tmp/acompose-main-check de934cc cd /tmp/acompose-main-check && sh scripts/smoke.sh ``` ## What did change here `12c7198` renamed the slugs the smoke drives: the composed-skill role binding, the launched role, the projected `role-*` and `personality-*` skill paths, and the assertion strings that name them. Those edits are mechanical and do not touch either failing assertion.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

coilyco-flight-deck/agent-compose#319

No description provided.

Rows
Columns

just smoke fails on two stale assertions, and has been red on main since before the reflow #319

Failure one

Failure two

Reproduction

What did change here

`just smoke` fails on two stale assertions, and has been red on main since before the reflow #319