coilyco-bridge/sirens-discord-ops
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Land code-comments cleanup - blocked on coily lockdown and assets/README.md #9

New issue
Closed
opened 2026-05-27 00:36:33 +00:00 by coilysiren · 1 comment
coilysiren commented 2026-05-27 00:36:33 +00:00
Owner
Copy link

Status

The 41 code-comments source fixes landed in the working tree (staged on main, not committed) per forgejo coilysiren/sirens-discord-ops#8. The commit is blocked by two pre-existing issues the pre-commit suite catches against staged state.

Blocker 1: .claude/lockdown-deny.sh lines 2-6

Coily-generated file has a 5-line contiguous comment block in HEAD, which fails code-comments. The auto-mode classifier blocks both the sub-agent and the parent from hand-editing this file (Self-Modification scope).

This is upstream a coily bug: coily's lockdown template ships a non-compliant comment block. Fix paths:

  1. Fix coily's lockdown template so the regenerated file is compliant. Out of scope per Kai's "avoid coily/infrastructure" instruction this session, but the right long-term fix.
  2. Kai hand-edits .claude/lockdown-deny.sh to collapse the block to one line, then runs git commit herself. Last-pushed wins, so next coily lockdown --apply --replace may regenerate the violation until path 1 lands.

Blocker 2: assets/README.md (documentation-layout)

Pre-existing markdown outside the allowed roots. Useful prose (banner.png attribution / LCARS visual idiom credit). Fix paths:

  1. Move to docs/assets.md and update any link from the repo root README.
  2. Delete (lose the attribution).
  3. Commit the code-comments work with SKIP=documentation-layout git commit ... to land this slice. Acceptable since the violation isn't a regression from this commit, but leaves the docs-layout cleanup floating.

Recommended: move to docs/assets.md and land sirens-discord-ops#8 cleanly.

Current working-tree state in /Users/kai/projects/coilysiren/sirens-discord-ops/:

Staged: .pre-commit-config.yaml (rev bump v0.2.6 -> v0.2.8), internal/bot/{bot,coily,config,games}.go, scripts/{install,start}.sh. Unstaged: .claude/settings.json (coily-managed drift, sweep separately).

**Status** The 41 code-comments source fixes landed in the working tree (staged on `main`, not committed) per forgejo coilysiren/sirens-discord-ops#8. The commit is blocked by two pre-existing issues the pre-commit suite catches against staged state. **Blocker 1: `.claude/lockdown-deny.sh` lines 2-6** Coily-generated file has a 5-line contiguous comment block in HEAD, which fails `code-comments`. The auto-mode classifier blocks both the sub-agent and the parent from hand-editing this file (Self-Modification scope). This is upstream a coily bug: coily's lockdown template ships a non-compliant comment block. Fix paths: 1. Fix coily's lockdown template so the regenerated file is compliant. Out of scope per Kai's "avoid coily/infrastructure" instruction this session, but the right long-term fix. 2. Kai hand-edits `.claude/lockdown-deny.sh` to collapse the block to one line, then runs `git commit` herself. Last-pushed wins, so next `coily lockdown --apply --replace` may regenerate the violation until path 1 lands. **Blocker 2: `assets/README.md` (documentation-layout)** Pre-existing markdown outside the allowed roots. Useful prose (banner.png attribution / LCARS visual idiom credit). Fix paths: 1. Move to `docs/assets.md` and update any link from the repo root README. 2. Delete (lose the attribution). 3. Commit the code-comments work with `SKIP=documentation-layout git commit ...` to land this slice. Acceptable since the violation isn't a regression from this commit, but leaves the docs-layout cleanup floating. Recommended: move to `docs/assets.md` and land sirens-discord-ops#8 cleanly. **Current working-tree state in `/Users/kai/projects/coilysiren/sirens-discord-ops/`:** Staged: `.pre-commit-config.yaml` (rev bump v0.2.6 -> v0.2.8), `internal/bot/{bot,coily,config,games}.go`, `scripts/{install,start}.sh`. Unstaged: `.claude/settings.json` (coily-managed drift, sweep separately).
coilysiren commented 2026-05-30 05:43:44 +00:00
Author
Owner
Copy link

Merged into #7 in the 2026-05-29 backlog burn-down. Code-comments cleanup landing, same cluster as #7 Reopen if it should stand alone.

Merged into #7 in the 2026-05-29 backlog burn-down. Code-comments cleanup landing, same cluster as #7 Reopen if it should stand alone.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
  
P0
now / blocking / urgent

  
P1
next / important

  
P2
backlog / will do

  
P3
someday / low

  
P4
icebox / frozen / reopen if it becomes real

No labels
P0
P1
P2
P3
P4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
coilyco-bridge/sirens-discord-ops#9
No description provided.